-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[Backport/v1.15] Escape git fetch remote (#19487) #19728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lunny mentioned that there would be some docker tag conflicts. I'm not sure whether it could be a blocker. If there is a chance, a fix for 1.15.x is good.
@wxiaoguang you are right in this old branch we did not updated the docker manifest creation ... I'll edit them |
When you tag in v1.15, latest will point to the newly created docker. Then users will switch from 1.16.7 to 1.15.12 when upgrade. |
we wont release so we wont tag ... |
If we won't tag, why did you change the ci file? |
hmm the project did fal apart :O - ci just dont like to run anymore |
-> sorry it wont build anymore |
backport #19487