Skip to content

[Backport/v1.15] Escape git fetch remote (#19487) #19728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented May 16, 2022

backport #19487

@6543 6543 added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label May 16, 2022
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lunny mentioned that there would be some docker tag conflicts. I'm not sure whether it could be a blocker. If there is a chance, a fix for 1.15.x is good.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 16, 2022
@6543 6543 mentioned this pull request May 16, 2022
@6543
Copy link
Member Author

6543 commented May 16, 2022

@wxiaoguang you are right in this old branch we did not updated the docker manifest creation ...

I'll edit them

@lunny
Copy link
Member

lunny commented May 16, 2022

When you tag in v1.15, latest will point to the newly created docker. Then users will switch from 1.16.7 to 1.15.12 when upgrade.

@6543
Copy link
Member Author

6543 commented May 16, 2022

we wont release so we wont tag ...

@lunny
Copy link
Member

lunny commented May 16, 2022

If we won't tag, why did you change the ci file?

@6543
Copy link
Member Author

6543 commented May 16, 2022

hmm the project did fal apart :O - ci just dont like to run anymore

@6543
Copy link
Member Author

6543 commented May 16, 2022

-> sorry it wont build anymore

@6543 6543 closed this May 16, 2022
@6543 6543 deleted the backport_v15_19487 branch May 16, 2022 15:26
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants