Skip to content

Don't open new page for ext wiki on same repository (#20725) #20910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 22, 2022
Merged

Don't open new page for ext wiki on same repository (#20725) #20910

merged 4 commits into from
Aug 22, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Aug 22, 2022 •
edited by zeripath
Loading

Fix #20657

Don't open new page for ext wiki on same repository (go-gitea#20725)
b5485ca 
- Backport of go-gitea#20725
  - When the external wiki has been set to a file on the repository, don't open the page on a tab.
  - Resolves go-gitea#20657
@Gusted Gusted added this to the 1.17.2 milestone Aug 22, 2022
@Gusted Gusted added the type/enhancement An improvement of existing functionality label Aug 22, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 22, 2022
@zeripath
Copy link
Contributor

Looks like the CI failure is related:

panic: template: repo/header:209: function "HasPrefix" not defined

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 22, 2022
@techknowlogick techknowlogick merged commit c0754e9 into go-gitea:release/v1.17 Aug 22, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.17.2
Development

Successfully merging this pull request may close these issues.
5 participants
@Gusted @zeripath @silverwind @techknowlogick @GiteaBot