Skip to content

Add a stars link to the repo listed in dashboard repolist #22816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add a stars link to the repo listed in dashboard repolist #22816

wants to merge 3 commits into from

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Feb 8, 2023

I think it is better to add a stars link to the repo listed in dashboard repolist.

@techknowlogick techknowlogick added this to the 1.20.0 milestone Feb 8, 2023
@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Feb 8, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 8, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Feb 9, 2023

image

@silverwind
Copy link
Member

Seems this PR was missed, needs a rebase now because of SFC refactoring I think.

@lafriks
Copy link
Member

lafriks commented Mar 16, 2023 •
edited
Loading

From UX perspective imho it creates too much information that are secondary. I would understand if it was in repository explore page where that could be useful information but I don't see much added info in quick repository access list. Also imho it adds confusing feeling that I can star them and that would affect that they are shown on top of this list. Just noticed that stars are shown already there and this PR just adds link. I would be for removing stars from this list

@silverwind
Copy link
Member

Agree on stars removal there. The list is fixed width and it takes away space for long repo names. GitHub frontpage Top Repositories also does not include stars fwiw.

@yp05327
Copy link
Contributor Author

yp05327 commented Mar 16, 2023

Agree to remove stars.

@silverwind
Copy link
Member

silverwind commented Mar 16, 2023 •
edited
Loading

Wanna make a new PR for it?

@go-gitea go-gitea deleted a comment from yp05327 Mar 16, 2023
@yp05327 yp05327 mentioned this pull request Mar 17, 2023
Merged
@yp05327
Copy link
Contributor Author

yp05327 commented Mar 17, 2023

Wanna make a new PR for it?

Yes. A new PR for it. And close this one.

@yp05327 yp05327 closed this Mar 17, 2023
techknowlogick pushed a commit that referenced this pull request Mar 17, 2023
@yp05327
Remove stars in dashboard repo list (#23530)
06c067b 
Discussion is here: #22816
@lunny lunny removed this from the 1.20.0 milestone Mar 18, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yp05327 @silverwind @lafriks @lunny @techknowlogick @GiteaBot