Skip to content

Rework Fork Page #24130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Rework Fork Page #24130

wants to merge 4 commits into from

Conversation

JakobDev
Copy link
Contributor

This is a rework of the Fork Page. It is currently WIP, that's why I don't use translations at the time and the code could maybe be improved. All features are working. It is inspired by the new GitHub Fork Page, but I had the Plans for doing a rework a little bit longer. Just tell me what you think and what features are you missing. The design is not considered final at the Moment, because I will like there are things that could be done better, but I can't say exactly what. Ideas how to make this better are very welcome.

btw:
I noticed that the translation of the title (the one you see in your browser tab) does not work, but that is not cursed by this PR.

grafik

@techknowlogick
Copy link
Member

@JakobDev are you in our discord chat?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 14, 2023
@JakobDev
Copy link
Contributor Author

No, why?

@silverwind
Copy link
Member

Seems better than the barebones page that was before, but alignment and margins in the screenshot definite need tuning. I'd also consider making actual boxes like GH, with rounded corner and all. If you get a basic layout done, I'm sure we can fine-tune CSS.

@silverwind
Copy link
Member

silverwind commented Apr 19, 2023

Idea: Make a shareable template with the repo list from the /explore/repos. A list of forks is a list of repos, so they can share the template.

More similar lists in org page, user page repo tab etc. Could all share a template.

@JakobDev
Copy link
Contributor Author

Idea: Make a shareable template with the repo list from the /explore/repos. A list of forks is a list of repos, so they can share the template.

This will not work. While it looks overall the same (what it should do), there a little differences. e.g the List of the Org/User Page does not cnatin the Owner for obvious reason. For the Fork Page, we don't want to show the "this is a Fork icon" for each Repo.

Seems better than the barebones page that was before, but alignment and margins in the screenshot definite need tuning.

What do you have in mind?

I'd also consider making actual boxes like GH, with rounded corner and all.

I thinks it's the best the keep the Design of a List of Repos overall the same in Gitea.

@silverwind
Copy link
Member

Based on:

image

  • Make margins equal top and bottom, and probably reduce them a small bite.
  • Vertically center repo name on avatar, best done with flexbox.
  • Put a interpunct between created and updated.
  • Add margin or single space character around "/"

@JakobDev
Copy link
Contributor Author

* Make margins equal top and bottom, and probably reduce them a small bite.

If you mean the 2 above and below, hey are the same size

* Vertically center repo name on avatar, best done with flexbox.

Done

* Put a interpunct between created and updated.

The already have a space. Do you mean something like ;?

* Add margin or single space character around "/"

Done

New Design:
grafik

@silverwind
Copy link
Member

silverwind commented Apr 21, 2023

If you mean the 2 above and below, hey are the same size

They looked differently, but might be a misgauge from me. Will verify later myself.

The already have a space. Do you mean something like ;?

I mean · aka the Interpunct. It's in use in a few places and I think a good fit there.

New Design:

Please add gt-mr-3 or even gt-mr-4 to the avatar to provide needed spacing

@JakobDev
Copy link
Contributor Author

New Screenshot:
grafik

@silverwind
Copy link
Member

Thanks, will review soon.

@lunny
Copy link
Member

lunny commented Jun 18, 2025

The forks list page should have a similar ui like /explore/repos, so that some templates could be reused.

@lunny
Copy link
Member

lunny commented Jun 19, 2025

Thanks for the contribution. This PR is outdated. It could be replaced by #34784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants