-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Rework Fork Page #24130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Fork Page #24130
Conversation
@JakobDev are you in our discord chat? |
No, why? |
Seems better than the barebones page that was before, but alignment and margins in the screenshot definite need tuning. I'd also consider making actual boxes like GH, with rounded corner and all. If you get a basic layout done, I'm sure we can fine-tune CSS. |
Idea: Make a shareable template with the repo list from the More similar lists in org page, user page repo tab etc. Could all share a template. |
This will not work. While it looks overall the same (what it should do), there a little differences. e.g the List of the Org/User Page does not cnatin the Owner for obvious reason. For the Fork Page, we don't want to show the "this is a Fork icon" for each Repo.
What do you have in mind?
I thinks it's the best the keep the Design of a List of Repos overall the same in Gitea. |
If you mean the 2 above and below, hey are the same size
Done
The already have a space. Do you mean something like ;?
Done |
They looked differently, but might be a misgauge from me. Will verify later myself.
I mean
Please add |
Thanks, will review soon. |
The forks list page should have a similar ui like |
Thanks for the contribution. This PR is outdated. It could be replaced by #34784 |
This is a rework of the Fork Page. It is currently WIP, that's why I don't use translations at the time and the code could maybe be improved. All features are working. It is inspired by the new GitHub Fork Page, but I had the Plans for doing a rework a little bit longer. Just tell me what you think and what features are you missing. The design is not considered final at the Moment, because I will like there are things that could be done better, but I can't say exactly what. Ideas how to make this better are very welcome.
btw:
I noticed that the translation of the title (the one you see in your browser tab) does not work, but that is not cursed by this PR.