Skip to content

Make mention autocomplete case insensitive in new markdown editor #24190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2023

Conversation

brechtvl
Copy link
Contributor

This matches EasyMDE, and makes it easier to find the right user without having to remember the exact name.

This matches EasyMDE, and makes it easier to find the right user without
having to remember the exact name.
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, an oversight from me.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 18, 2023
@silverwind
Copy link
Member

silverwind commented Apr 18, 2023

@brechtvl could you do the same for emoji on line 111? so "1ST" should still capture "1st" emoji when doing ":" autocompletion.

@silverwind silverwind added this to the 1.20.0 milestone Apr 18, 2023
@codecov-commenter

This comment was marked as off-topic.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 18, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2023
@silverwind silverwind enabled auto-merge (squash) April 18, 2023 16:52
@silverwind silverwind merged commit e541a8c into go-gitea:main Apr 18, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2023
@brechtvl brechtvl deleted the mention-case-insensitive branch May 20, 2023 12:48
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants