Add gitea manager reload-templates command

cmd/manager.go

@@ -21,6 +21,7 @@ var (
 		Subcommands: []cli.Command{
 			subcmdShutdown,
 			subcmdRestart,
+			subcmdReloadTemplates,
 			subcmdFlushQueues,
 			subcmdLogging,
 			subCmdProcesses,
@@ -46,6 +47,20 @@ var (
 		},
 		Action: runRestart,
 	}
+	subcmdReloadTemplates = cli.Command{
+		Name:  "reload-templates",
+		Usage: "Reload template files in the running process",
+		Flags: []cli.Flag{
+			cli.BoolFlag{
+				Name: "debug",
+			},
+			cli.BoolFlag{
+				Name:  "test",
+				Usage: "Test templates for errors without actually reloading",
+			},
+		},
+		Action: runReloadTemplates,
+	}
 	subcmdFlushQueues = cli.Command{
 		Name:   "flush-queues",
 		Usage:  "Flush queues in the running process",
@@ -115,6 +130,15 @@ func runRestart(c *cli.Context) error {
 	return handleCliResponseExtra(extra)
 }
 
+func runReloadTemplates(c *cli.Context) error {
+	ctx, cancel := installSignals()
+	defer cancel()
+
+	setup(ctx, c.Bool("debug"))
+	extra := private.ReloadTemplates(ctx, c.Bool("test"))
+	return handleCliResponseExtra(extra)
+}
+
 func runFlushQueues(c *cli.Context) error {
 	ctx, cancel := installSignals()
 	defer cancel()

modules/private/manager.go

@@ -29,6 +29,13 @@ func Restart(ctx context.Context) ResponseExtra {
 	return requestJSONUserMsg(req, "Restarting")
 }
 
+// ReloadTemplates calls the internal reload-templates function
+func ReloadTemplates(ctx context.Context, test bool) ResponseExtra {
+	reqURL := setting.LocalURL + fmt.Sprintf("api/internal/manager/reload-templates?test=%t", test)
+	req := newInternalRequest(ctx, reqURL, "POST")
+	return requestJSONUserMsg(req, "Reloaded")
+}
+
 // FlushOptions represents the options for the flush call
 type FlushOptions struct {
 	Timeout     time.Duration

modules/templates/htmlrenderer.go

@@ -62,7 +62,7 @@ func (h *HTMLRender) TemplateLookup(name string) (TemplateExecutor, error) {
 	return tmpls.Executor(name, NewFuncMap())
 }
 
-func (h *HTMLRender) CompileTemplates() error {
+func (h *HTMLRender) CompileTemplates(test bool) error {
 	assets := AssetFS()
 	extSuffix := ".tmpl"
 	tmpls := scopedtmpl.NewScopedTemplate()
@@ -85,6 +85,9 @@ func (h *HTMLRender) CompileTemplates() error {
 			return err
 		}
 	}
+	if test {
+		return nil
+	}
 	tmpls.Freeze()
 	h.templates.Store(tmpls)
 	return nil
@@ -96,6 +99,16 @@ func HTMLRenderer() *HTMLRender {
 	return htmlRender
 }
 
+func ReloadHTMLTemplates(test bool) error {
+	if err := htmlRender.CompileTemplates(test); err != nil {
+		if !test {
+			log.Error("Template error: %v\n%s", err, log.Stack(2))
+		}
+		return err
+	}
+	return nil
+}
+
 func initHTMLRenderer() {
 	rendererType := "static"
 	if !setting.IsProd {
@@ -104,7 +117,7 @@ func initHTMLRenderer() {
 	log.Debug("Creating %s HTML Renderer", rendererType)
 
 	htmlRender = &HTMLRender{}
-	if err := htmlRender.CompileTemplates(); err != nil {
+	if err := htmlRender.CompileTemplates(false); err != nil {
 		p := &templateErrorPrettier{assets: AssetFS()}
 		wrapFatal(p.handleFuncNotDefinedError(err))
 		wrapFatal(p.handleUnexpectedOperandError(err))
@@ -115,9 +128,7 @@ func initHTMLRenderer() {
 
 	if !setting.IsProd {
 		go AssetFS().WatchLocalChanges(graceful.GetManager().ShutdownContext(), func() {
-			if err := htmlRender.CompileTemplates(); err != nil {
-				log.Error("Template error: %v\n%s", err, log.Stack(2))
-			}
+			_ = ReloadHTMLTemplates(false)
 		})
 	}
 }

routers/private/internal.go

@@ -67,6 +67,7 @@ func Routes() *web.Route {
 	r.Get("/serv/command/{keyid}/{owner}/{repo}", ServCommand)
 	r.Post("/manager/shutdown", Shutdown)
 	r.Post("/manager/restart", Restart)
+	r.Post("/manager/reload-templates", ReloadTemplates)
 	r.Post("/manager/flush-queues", bind(private.FlushOptions{}), FlushQueues)
 	r.Post("/manager/pause-logging", PauseLogging)
 	r.Post("/manager/resume-logging", ResumeLogging)

routers/private/manager.go

@@ -15,9 +15,23 @@ import (
 	"code.gitea.io/gitea/modules/private"
 	"code.gitea.io/gitea/modules/queue"
 	"code.gitea.io/gitea/modules/setting"
+	"code.gitea.io/gitea/modules/templates"
 	"code.gitea.io/gitea/modules/web"
 )
 
+// ReloadTemplates reloads all the templates
+func ReloadTemplates(ctx *context.PrivateContext) {
+	test := ctx.FormBool("test")
+	err := templates.ReloadHTMLTemplates(test)
+	if err != nil {
+		ctx.JSON(http.StatusInternalServerError, private.Response{
+			UserMsg: fmt.Sprintf("Template error: %v", err),
+		})
+		return
+	}
+	ctx.PlainText(http.StatusOK, "success")
+}
+
 // FlushQueues flushes all the Queues
 func FlushQueues(ctx *context.PrivateContext) {
 	opts := web.GetForm(ctx).(*private.FlushOptions)