-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
fix tags line no margin #25255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tags line no margin #25255
Conversation
templates/explore/repo_list.tmpl
Outdated
@@ -54,9 +54,9 @@ | |||
{{$description := .DescriptionHTML $.Context}} | |||
{{if $description}}<p>{{$description}}</p>{{end}} | |||
{{if .Topics}} | |||
<div class="ui tags"> | |||
<div class="gt-df gt-fw gt-gap-2 gt-mb-3 gt-font-normal gt-font-14"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "gt-font-normal gt-font-14" do here? Why two font styles.
And, if you think the font is too small, you can just remove the "small" class from the "label", but not use these gt-font-xxx
patches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normal is weight, 14 is size, so two classes is correct to override both. It might be that fomantic styles are interfering too much, not sure if there are better solutions. I do agree previous labels were too small.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then do not use "small label", overwriting styles is really fragile, and it bloats the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
- Don't run DB tests for frontend-only changes - Build frontend as part of frontend step - Build everything when actions change
The code can be as simple as: ```html <div class="flex-text-block">{{svg "octicon-alert"}} {{svg "octicon-x"}} text (block)</div> <div><div class="flex-text-inline">{{svg "octicon-alert"}} {{svg "octicon-x"}} text</div> (inline)</div> <div><button class="ui red button">{{svg "octicon-alert" 24}} {{svg "octicon-x" 24}} text</button></div> ```  --------- Co-authored-by: Giteabot <[email protected]>
The `<div class="ui container">` broke the width of this section - fix by removing it.
So I found this [linter](https://github.com/Riverside-Healthcare/djlint) which features a mode for go templates, so I gave it a try and it did find a number of valid issue, like unbalanced tags etc. It also has a number of bugs, I had to disable/workaround many issues. Given that this linter is written in python, this does add a dependency on `python` >= 3.8 and `poetry` to the development environment to be able to run this linter locally. - `e.g.` prefixes on placeholders are removed because the linter had a false-positive on `placeholder="e.g. cn=Search"` for the `attr=value` syntax and it's not ideal anyways to write `e.g.` into a placeholder because a placeholder is meant to hold a sample value. - In `templates/repo/settings/options.tmpl` I simplified the logic to not conditionally create opening tags without closing tags because this stuff confuses the linter (and possibly the reader as well).
This is my first pr, there are many things I don't understand very well, I am very sorry, I rearranged the code and opened this new pr. Now: 
Before:

After:
