Skip to content

Allow change line of admin-dl-horizontal dt #25508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2023
Merged

Allow change line of admin-dl-horizontal dt #25508

merged 2 commits into from
Jun 26, 2023

Conversation

HesterG
Copy link
Contributor

@HesterG HesterG commented Jun 26, 2023 •
edited
Loading

Close #25389

After:

Screen Shot 2023-06-26 at 11 00 12

admin/dashboard:

Screen Shot 2023-06-26 at 10 59 51

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 26, 2023
@wxiaoguang
Copy link
Contributor

I do not think it's right .... actually, it should allow text breaking/wrapping.

@HesterG HesterG changed the title Increase width of admin-dl-horizontal dt Allow change line of admin-dl-horizontal dt Jun 26, 2023
@HesterG
Copy link
Contributor Author

HesterG commented Jun 26, 2023

I do not think it's right .... actually, it should allow text breaking/wrapping.

Removed ellipsis instead, and updated screenshots.

@lunny lunny added topic/ui Change the appearance of the Gitea UI backport/v1.20 This PR should be backported to Gitea 1.20 labels Jun 26, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 26, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2023
@lunny lunny merged commit 457946d into go-gitea:main Jun 26, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jun 26, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 26, 2023 •
edited
Loading

It's merged too fast ............

@wxiaoguang wxiaoguang mentioned this pull request Jun 26, 2023
Merged
@wxiaoguang
Copy link
Contributor

Please review this one

Fix admin-dl-horizontal #25512

GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 26, 2023
@HesterG @GiteaBot
Allow change line of admin-dl-horizontal dt (go-gitea#25508)
aa96a91 
Close go-gitea#25389

After:

<img width="915" alt="Screen Shot 2023-06-26 at 11 00 12"
src="https://github.com/go-gitea/gitea/assets/17645053/45026447-cf50-4603-ade3-7b80a9023c20">


admin/dashboard:

<img width="957" alt="Screen Shot 2023-06-26 at 10 59 51"
src="https://github.com/go-gitea/gitea/assets/17645053/f4f95bbe-f747-46f1-8fbd-5778a19ebef7">
@GiteaBot GiteaBot mentioned this pull request Jun 26, 2023
Closed
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jun 26, 2023
HesterG added a commit to HesterG/gitea that referenced this pull request Jun 26, 2023
@HesterG
Allow change line of admin-dl-horizontal dt (go-gitea#25508)
cfb51fb 
Close go-gitea#25389

After:

<img width="915" alt="Screen Shot 2023-06-26 at 11 00 12"
src="https://github.com/go-gitea/gitea/assets/17645053/45026447-cf50-4603-ade3-7b80a9023c20">


admin/dashboard:

<img width="957" alt="Screen Shot 2023-06-26 at 10 59 51"
src="https://github.com/go-gitea/gitea/assets/17645053/f4f95bbe-f747-46f1-8fbd-5778a19ebef7">
silverwind pushed a commit that referenced this pull request Jun 26, 2023
@HesterG @GiteaBot
Allow change line of admin-dl-horizontal dt (#25508) (#25516)
40744f8 
As #25515 (comment)
says, still need this backport

Close #25389

After:

<img width="915" alt="Screen Shot 2023-06-26 at 11 00 12"
src="https://github.com/go-gitea/gitea/assets/17645053/45026447-cf50-4603-ade3-7b80a9023c20">


admin/dashboard:

<img width="957" alt="Screen Shot 2023-06-26 at 10 59 51"
src="https://github.com/go-gitea/gitea/assets/17645053/f4f95bbe-f747-46f1-8fbd-5778a19ebef7">

Co-authored-by: Giteabot <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.20 This PR should be backported to Gitea 1.20 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

Full config options are not visible in admin/config page
5 participants
@HesterG @wxiaoguang @lunny @techknowlogick @GiteaBot