Skip to content

Use flex instead of float for sort button and search input #25519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 28, 2023
Merged

Use flex instead of float for sort button and search input #25519

merged 10 commits into from
Jun 28, 2023

Conversation

HesterG
Copy link
Contributor

@HesterG HesterG commented Jun 26, 2023 •
edited
Loading

Right now some sort buttons beside search input are unclickable because #25338 removed max-width and the sort button is using float, sort button is then covered by the input.

The way to fix this in this PR is changing the layout to flex and put input form and sort button into secondary menu.

After:

Screen Shot 2023-06-26 at 16 40 52 Screen Shot 2023-06-26 at 16 34 06 Screen Shot 2023-06-26 at 16 34 22 Screen Shot 2023-06-26 at 16 34 32 Screen Shot 2023-06-26 at 16 35 21 Screen Shot 2023-06-26 at 16 36 14

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 26, 2023
@HesterG HesterG added the topic/ui Change the appearance of the Gitea UI label Jun 26, 2023
@silverwind
Copy link
Member

Ah, so the max-width did serve a (hacky) purpose.

@silverwind
Copy link
Member

Note: templates/code/searchform.tmpl is the only form left with a max-width in templates, we should fix it here as well.

@silverwind
Copy link
Member

silverwind commented Jun 26, 2023 •
edited
Loading

Noticed on user page that the form now renders slightly outside its container:

Screenshot 2023-06-26 at 20 41 05 Screenshot 2023-06-26 at 20 42 54

This is because of negative margins on fomantic .ui.secondary.menu.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 26, 2023
silverwind
silverwind approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find any more similar issues, so LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 26, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 28, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Jun 28, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 28, 2023
@lunny lunny merged commit c082689 into go-gitea:main Jun 28, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 28, 2023
@HesterG HesterG deleted the adjust-repo-search branch June 29, 2023 00:44
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@HesterG @silverwind @wxiaoguang @lunny @GiteaBot