Skip to content

Align language menu icon and fit the footer area #25556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 28, 2023
Merged

Align language menu icon and fit the footer area #25556

merged 4 commits into from
Jun 28, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jun 28, 2023 •
edited
Loading

Close #25551

Before

image

After

image

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 28, 2023
@wxiaoguang wxiaoguang added the backport/v1.20 This PR should be backported to Gitea 1.20 label Jun 28, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Jun 28, 2023
@wxiaoguang wxiaoguang marked this pull request as draft June 28, 2023 07:24
@wxiaoguang wxiaoguang changed the title Align language menu icon Align language menu icon and fit the footer area Jun 28, 2023
@wxiaoguang wxiaoguang force-pushed the fix-language-menu-icon branch from c2d6bd8 to a4d3f7d Compare June 28, 2023 07:35
@wxiaoguang wxiaoguang force-pushed the fix-language-menu-icon branch from a4d3f7d to d8ecd6e Compare June 28, 2023 07:37
@wxiaoguang wxiaoguang marked this pull request as ready for review June 28, 2023 07:38
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 28, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 28, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 28, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) June 28, 2023 14:32
@techknowlogick techknowlogick merged commit b6693a2 into go-gitea:main Jun 28, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 28, 2023
@wxiaoguang @GiteaBot
Align language menu icon and fit the footer area (go-gitea#25556)
f494335 
Close go-gitea#25551
@GiteaBot GiteaBot mentioned this pull request Jun 28, 2023
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jun 28, 2023
@wxiaoguang wxiaoguang deleted the fix-language-menu-icon branch June 28, 2023 15:21
silverwind pushed a commit that referenced this pull request Jun 28, 2023
@GiteaBot @wxiaoguang
Align language menu icon and fit the footer area (#25556) (#25563)
7222bac 
Backport #25556 by @wxiaoguang

Close #25551

## Before


![image](https://github.com/go-gitea/gitea/assets/2114189/f35aebeb-9c86-4632-8c1f-1c90aa757640)

## After



![image](https://github.com/go-gitea/gitea/assets/2114189/4a623687-6c6d-442a-a4f9-07dadeb9fc6d)


----


![image](https://github.com/go-gitea/gitea/assets/2114189/6a4e5ecf-b88b-4c22-98c3-21898bd41bc5)

Co-authored-by: wxiaoguang <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.20 This PR should be backported to Gitea 1.20 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

Language Switch select style optimization of Icon and Text a align
5 participants
@wxiaoguang @lunny @delvh @techknowlogick @GiteaBot