Skip to content

Fix can_push value to false in protected_branch #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2017
Merged

Fix can_push value to false in protected_branch #2560

merged 2 commits into from
Sep 20, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Sep 20, 2017

Needed for #2556 and for future option to be able to specify that branch can be pushed to always but are protected only from deletion

@lafriks lafriks added backport/v1.2 issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change labels Sep 20, 2017
@lafriks lafriks added this to the 1.3.0 milestone Sep 20, 2017
@lafriks lafriks mentioned this pull request Sep 20, 2017
Merged
@daviian
Copy link
Member

daviian commented Sep 20, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 20, 2017
@codecov-io
Copy link

codecov-io commented Sep 20, 2017 •
edited
Loading

Codecov Report

Merging #2560 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2560   +/-   ##
=======================================
  Coverage   26.99%   26.99%           
=======================================
  Files          85       85           
  Lines       17097    17097           
=======================================
  Hits         4615     4615           
  Misses      11807    11807           
  Partials      675      675
Impacted Files Coverage Δ
models/branches.go 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f380a2...0ead9e5. Read the comment docs.

@lunny
Copy link
Member

lunny commented Sep 20, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 20, 2017
@lafriks lafriks merged commit 6718ea6 into go-gitea:master Sep 20, 2017
@lafriks lafriks deleted the fix_protected_branch_can_push branch September 20, 2017 15:06
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Sep 20, 2017
@lafriks
Fix can_push value to false in protected_branch (go-gitea#2560)
918f0d4
@lafriks lafriks added the backport/done All backports for this PR have been created label Sep 20, 2017
lafriks added a commit that referenced this pull request Sep 20, 2017
@lafriks
Fix adding branch as protected to not allow pushing to it (#2556)
25e71ad 
* Fix adding branch as protected to not allow pushing to it

* Fix can_push value to false in protected_branch (#2560)

* Fix integration test
@daviian daviian mentioned this pull request Sep 21, 2017
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @daviian @codecov-io @lunny @tboerger