[TESTS] auth LinkAccount test coverage #25663
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 6623630d1070c6c0f195197ad769b2aed15a50b9) (cherry picked from commit d30b9dc5b43da2ce3ecb24c0d2d1c47ea7582f65) (cherry picked from commit 8e790a6)
(cherry picked from commit c1d14c5fffeb823385b2984cfcdb3e195bfb151d) (cherry picked from commit e0e8aabc985af153cf1fcb2064c17f68ec37f3a2) (cherry picked from commit 392a415)
(cherry picked from commit e11dcc60f291f1b882a993f60f8381fe4561d6d0) use backticks to avoid backslash (cherry picked from commit 34212791eef2031ef09ea118a2ee5b98082174dc) (cherry picked from commit bde9473c69eaf6306457b4218d9704af64cb6cc8) (cherry picked from commit d4deb43)
GiteaBot
added
the
lgtm/need 2
delvh
approved these changes
Jul 7, 2023
GiteaBot
added
lgtm/need 1
techknowlogick
previously requested changes
Jul 7, 2023
GiteaBot
added
lgtm/blocked
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Jul 8, 2023
Comment on lines
+254
to
+256
| return func() { | ||
| assert.NoError(t, user_service.DeleteUser(context.Background(), u, true)) | ||
| } |
There was a problem hiding this comment.
I think there is no need to do so. PrepareTestEnv will reset all test data
wxiaoguang
reviewed
Jul 8, 2023
| @@ -104,7 +104,7 @@ func ctxDataSet(args ...any) func(ctx *context.Context) { | |||
| } | |||
|
|
|||
| // Routes returns all web routes | |||
| func Routes() *web.Route { | |||
| func Routes(middlewares ...any) *web.Route { | |||
There was a problem hiding this comment.
middlewares ...any introduces strange smell to the code base, no comment, and it might be abused in the future. And it's unclear what's the proper order for these middlewares, how they co-work with other middlewares.
wxiaoguang
reviewed
Jul 8, 2023
| _ = templates.HTMLRenderer() | ||
| r := web.NewRoute() | ||
| r.Use(common.ProtocolMiddlewares()...) | ||
|
|
||
| r.Mount("/", web_routers.Routes()) | ||
| r.Mount("/", web_routers.Routes(middlewares...)) |
There was a problem hiding this comment.
I can understand the logic by reading this PR, but, it will be a problem for future developers: why the "middlewares" appear here? Why it only applies to "/" ? How it co-work with others?
TBH, I do not think it is a good design.
|
-> Make route middleware/handler mockable #25766 defer web.RouteMockReset()
...
web.RouteMock(web.MockAfterMiddlewares, func(ctx *context.Context) {
ctx.Session.Set("linkAccountGothUser", testCase.gothUser)
}) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.