Skip to content

Apply to became a maintainer. #25745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2023
Merged

Apply to became a maintainer. #25745

merged 2 commits into from
Jul 7, 2023

Conversation

puni9869
Copy link
Member

@puni9869 puni9869 commented Jul 7, 2023 •
edited
Loading

Hi Gitea Team,
I would like to apply as a maintainer.
I don't have that much in-depth knowledge of the codebase, but I would like to help to review PRs for the beginning in my free time and contribute in frontend, backend tasks and new proposals.

Here is my PR list:- https://github.com/go-gitea/gitea/pulls?q=is%3Apr+author%3Apuni9869+is%3Amerged+

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 7, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 7, 2023
@wolfogre
Copy link
Member

wolfogre commented Jul 7, 2023 •
edited
Loading

Welcome! 🎉

BTW, maybe "Add myself to maintainers" or "Apply to become a maintainer" is good enough as the title. I am not a native English speaker, I can understand "Application as a maintainer", but it sounds weird to me, something like:

Just a friendly joke, if you feel it offensive, I will remove it

image

Never mind, welcome again!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 7, 2023
@puni9869 puni9869 changed the title Application as a maintainer. Apply as a maintainer. Jul 7, 2023
@puni9869 puni9869 changed the title Apply as a maintainer. Apply to became a maintainer. Jul 7, 2023
@puni9869
Copy link
Member Author

puni9869 commented Jul 7, 2023

Welcome! 🎉

BTW, maybe "And myself to maintainers" or "Apply to become a maintainer" is good enough as the title. I am not a native English speaker, I can understand "Application as a maintainer", but it sounds weird to me, something like:

Just a friendly joke, if you find it offensive, I will remove it

image

Never mind, welcome again!

Haha.. Its fine.

@6543
Copy link
Member

6543 commented Jul 7, 2023

@puni9869 whats your discord handle?

@6543 6543 merged commit 32b2618 into go-gitea:main Jul 7, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jul 7, 2023
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 7, 2023
@puni9869
Copy link
Member Author

puni9869 commented Jul 7, 2023

@puni9869 whats your discord handle?

The same as @puni9869

@delvh
Copy link
Member

delvh commented Jul 7, 2023 •
edited
Loading

(Sidenote: That was not relevant anymore, as I was already able to make you a maintainer in Discord 😄)

@puni9869
Copy link
Member Author

puni9869 commented Jul 7, 2023

(Sidenote: That was not relevant anymore, as I was already able to make you a maintainer in Discord 😄)

For the record...

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@wolfogre wolfogre wolfogre approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
8 participants
@puni9869 @wolfogre @6543 @delvh @lunny @KN4CK3R @wxiaoguang @GiteaBot