Skip to content

Add pre-build step for nodejs stuff #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2017
Merged

Add pre-build step for nodejs stuff #2581

merged 1 commit into from
Sep 24, 2017

Conversation

Morlinest
Copy link
Member

As title. Based (=contains) on #2580 (need to be merged first, then I'll rebase this one). Only .drone.yml file contains related changes.

Instead of installing node on each PR, use image with nodejs and run nodejs stuff there.

@tboerger Please take a look.

tboerger
tboerger reviewed Sep 22, 2017
View reviewed changes
.drone.yml Outdated
@@ -9,23 +9,29 @@ clone:
tags: true

pipeline:
pre-build:
image: webhippie/nodejs:edge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edge doesn't exist, just use latest which is based on regular alpine edge packaging.

@codecov-io
Copy link

codecov-io commented Sep 22, 2017 •
edited
Loading

Codecov Report

Merging #2581 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2581   +/-   ##
=======================================
  Coverage   27.33%   27.33%           
=======================================
  Files          86       86           
  Lines       17137    17137           
=======================================
  Hits         4684     4684           
  Misses      11775    11775           
  Partials      678      678

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 086eb62...c3bac73. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 22, 2017
@lunny lunny added this to the 1.3.0 milestone Sep 23, 2017
@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Sep 23, 2017
daviian
daviian suggested changes Sep 23, 2017
View reviewed changes
.drone.yml
- make generate
- make vet
- make lint
- make fmt-check
- make stylesheets-check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing stylesheets-check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to pre-build step.

.drone.yml Outdated
- make clean
- make minify
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minify can be moved after stylesheets-check to prevent unnecessary build step execution

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be runned before make generate.

@lafriks
Copy link
Member

lafriks commented Sep 23, 2017

I'm against that unminified file is stored in repository. Idea is to have all files in that condition so that you can go get and go build and you don't need any other tools to run it. Of course development requires more tools/steps but just compiling from source should not.

@tboerger
Copy link
Member

IMHO @lafriks is right.

@Morlinest Morlinest mentioned this pull request Sep 24, 2017
Merged
@Morlinest
Copy link
Member Author

@lafriks What other tools? The file is there, only it is not minified. Anyway, this should be discussed in #2580.

@lafriks
Copy link
Member

lafriks commented Sep 24, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 24, 2017
@daviian
Copy link
Member

daviian commented Sep 24, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 24, 2017
@lafriks lafriks merged commit 0b0d85c into go-gitea:master Sep 24, 2017
@Morlinest Morlinest deleted the fix/add-nodejs-step branch September 24, 2017 21:49
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tboerger tboerger tboerger left review comments

@daviian daviian daviian approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Morlinest @codecov-io @lafriks @tboerger @daviian @lunny