Downloading translations and ignoring branch at Crowdin #2592

jonasfranz · 2017-09-23T21:23:44Z

This PR adds the following build steps:

download_translations: Downloads & exports all translations from crowdin and saves them into options/locale/
upload_translations: Uploads the updated locale_en-US.ini to Crowdin

The build steps are splitted because the files should only uploaded to crowdin if all test passes.

It also adds the ignore_branch option to fix the build process because gitea does not use branches at crowdin.

This is already tested here:

Upload & Export in custom folder: http://drone.jonasfranz.software/JonasFranzDEV/Crowdin-Demo/12
Used configuration: https://git.jonasfranz.software/JonasFranzDEV/Crowdin-Demo/src/master/.drone.yml

Related to #2585
Related to jonasfranz/drone-crowdin#2

codecov-io · 2017-09-23T21:37:45Z

Codecov Report

Merging #2592 into master will decrease coverage by 0.41%.
The diff coverage is 2.89%.

@@            Coverage Diff             @@
##           master    #2592      +/-   ##
==========================================
- Coverage   27.38%   26.96%   -0.42%     
==========================================
  Files          86       87       +1     
  Lines       17010    17297     +287     
==========================================
+ Hits         4658     4664       +6     
- Misses      11673    11953     +280     
- Partials      679      680       +1

Impacted Files	Coverage Δ
models/repo_branch.go	`8.73% <0%> (-24.61%)`	⬇️
models/repo_activity.go	`0% <0%> (ø)`
models/error.go	`18.93% <0%> (-1%)`	⬇️
routers/user/setting.go	`0% <0%> (ø)`	⬆️
modules/validation/binding.go	`100% <100%> (ø)`	⬆️
models/repo.go	`13.12% <5.4%> (-0.02%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4cd461...fe8c55f. Read the comment docs.

lafriks · 2017-09-23T22:48:29Z

I don't quite see point in downloading translations from crowdin. As we need to get these translations in git

lunny · 2017-09-24T05:46:02Z

Two options, one is manually download crowdin languages packs and send a PR, another is remove all language packs except en-US and download it before build.

jonasfranz · 2017-09-24T08:11:52Z

@lunny @lafriks I think that we need a combination out of both. So if you release a new version you should download the translations manually. If you build a master version you will get the translations on the fly via the build process.

lafriks · 2017-09-25T08:01:22Z

@JonasFranzDEV I like @tboerger idea that appleboy/drone-git-push could be used to push downloaded files to git

tboerger · 2017-09-25T08:35:52Z

@JonasFranzDEV I like @tboerger idea that appleboy/drone-git-push could be used to push downloaded files to git

In reference to #2585 (comment)

jonasfranz · 2017-09-26T08:43:12Z

@tboerger @lafriks I've added the git push part. The translations will be updated on GitHub too now.

tboerger · 2017-09-26T09:53:57Z

.drone.yml

+    image: appleboy/drone-git-push
+    pull: true
+    secrets: [ git_push_ssh_key ]
+    remote: "[email protected]:go-gitea/gitea.git"


I think we don't need the remote

tboerger · 2017-09-26T09:54:24Z

.drone.yml

+    pull: true
+    secrets: [ git_push_ssh_key ]
+    remote: "[email protected]:go-gitea/gitea.git"
+    branch: master


The branch should be already master?

lunny · 2017-10-13T12:34:38Z

.drone.yml

-
-  translations:
+
+  github:


This section seems not related?

@JonasFranzDEV why this section is needed here?

@lunny @lafriks As you can see in comments: this was a merge from master to pr branch. Think a full rebase is necessary.

@daviian What should I do for a "full rebase"?

git rebase master?

@JonasFranzDEV Usually I rebase my master to be the same as upstream/master (original gitea remote) and after checking out my pr branch I do it like @Morlinest said.

* remove orgnization watch repositories * fix migration * fix typo and missing change * remove unused code

…o-gitea#2678) * Allow custom SSH user in UI for built-in SSH server (go-gitea#2617) * Some fixes * Did make fmt * Updated according to review - Renamed config to BUILTIN_SSH_SERVER_USER - Removed unnecessary default string value for config item * Updated according to review * Fixed some minor issues

* Add Activity page to repository * Add request data for activity * Add issue data for activity * Add user unit right checks * Add releases to activity * Log repository unit loading error

…ions (go-gitea#2699) * Fix so that user can still fork his own repository to his organizations * Fix to only use owned organizations * Add integration test for forking own repository to owned organization

* provide both possible authentication solutions Signed-off-by: David Schneiderbauer <[email protected]>

* Create new branch from branch selection dropdown and rewrite it to VueJS * Make updateLocalCopyToCommit as not exported * Move branch name validation to model * Fix possible race condition

* Integration test for activity page * Small code refactoring for acitvity page * Move activity stats calculation logic to model

…2705) * fix plain readme didn't render correctly on repo home page * fix missing render * remove unused template variables

…o-gitea#2710) * Fix PR, milestone and label functionality if issue unit is disabled or not assigned to user * Fix multi-actions in PR page * Change error message * Fix comment update and delete functionality in PR

* merge password and 2fa page on user settings

Signed-off-by: Jonas Franz <[email protected]>

# Conflicts: # .drone.yml

jonasfranz · 2017-10-17T10:25:59Z

I've fully rebased it onto master. @Morlinest

Morlinest · 2017-10-17T11:29:09Z

I think something is wrong, 51 files changed.

daviian · 2017-10-17T15:02:35Z

@JonasFranzDEV Was your pr branch created from master!?

jonasfranz · 2017-10-17T15:49:42Z

Replaced by #2727

Adding download translations and ignoring branch

73041f3

tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 23, 2017

jonasfranz added 2 commits September 26, 2017 10:40

Adding git-push

6e178ea

Merge branch 'master' into patch-1

593fae2

tboerger reviewed Sep 26, 2017

View reviewed changes

jonasfranz added 2 commits September 26, 2017 13:00

Update .drone.yml

1db4eab

Merge branch 'master' into patch-1

9d36fac

lunny reviewed Oct 13, 2017

View reviewed changes

lunny and others added 15 commits October 14, 2017 22:37

Fix orgnization user watch repository (go-gitea#2670)

514006a

* remove orgnization watch repositories * fix migration * fix typo and missing change * remove unused code

Fix organization watch migration (go-gitea#2703)

8863e74

Add Activity page to repository (go-gitea#2674)

f42dbdb

* Add Activity page to repository * Add request data for activity * Add issue data for activity * Add user unit right checks * Add releases to activity * Log repository unit loading error

Remove direct user adding to organization members (go-gitea#2641)

32ca299

Fix so that user can still fork his own repository to owned organizat…

1ec4dc6

…ions (go-gitea#2699) * Fix so that user can still fork his own repository to his organizations * Fix to only use owned organizations * Add integration test for forking own repository to owned organization

fix .netrc authentication (go-gitea#2700)

4ccb0fe

* provide both possible authentication solutions Signed-off-by: David Schneiderbauer <[email protected]>

Fix activity locale (go-gitea#2709)

c25303b

Create new branch from branch selection dropdown (go-gitea#2130)

f3833b7

* Create new branch from branch selection dropdown and rewrite it to VueJS * Make updateLocalCopyToCommit as not exported * Move branch name validation to model * Fix possible race condition

Integration test for activity page (go-gitea#2704)

c7f4f07

* Integration test for activity page * Small code refactoring for acitvity page * Move activity stats calculation logic to model

Fix plain readme didn't render correctly on repo home page (go-gitea#…

a75d5c7

…2705) * fix plain readme didn't render correctly on repo home page * fix missing render * remove unused template variables

Merge password and 2fa page on user settings (go-gitea#2695)

9e865ce

* merge password and 2fa page on user settings

Fixing wrong translations on sorttype oldest/latest (go-gitea#2720)

33647aa

Render plain text README.txt monospaced (go-gitea#2721)

f4190f8

Signed-off-by: Jonas Franz <[email protected]>

lafriks and others added 5 commits October 17, 2017 02:24

Fix semantic-ui style conflict with v-cloak (go-gitea#2722)

af4a094

Adding download translations and ignoring branch

dc4b941

Adding git-push

6c95098

Update .drone.yml

baebafe

Merge remote-tracking branch 'jonas/patch-1' into patch-1

fe8c55f

# Conflicts: # .drone.yml

jonasfranz closed this Oct 17, 2017

jonasfranz mentioned this pull request Oct 17, 2017

Download and pushing translations #2727

Merged

go-gitea locked and limited conversation to collaborators Nov 23, 2020

Uh oh!

Downloading translations and ignoring branch at Crowdin #2592

Downloading translations and ignoring branch at Crowdin #2592

Uh oh!

Conversation

jonasfranz commented Sep 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Sep 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lafriks commented Sep 23, 2017

Uh oh!

lunny commented Sep 24, 2017

Uh oh!

jonasfranz commented Sep 24, 2017

Uh oh!

lafriks commented Sep 25, 2017

Uh oh!

tboerger commented Sep 25, 2017

Uh oh!

jonasfranz commented Sep 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonasfranz commented Oct 17, 2017

Uh oh!

Morlinest commented Oct 17, 2017

Uh oh!

daviian commented Oct 17, 2017

Uh oh!

jonasfranz commented Oct 17, 2017

Uh oh!

Uh oh!

jonasfranz commented Sep 23, 2017 •

edited

Loading

codecov-io commented Sep 23, 2017 •

edited

Loading