Skip to content

Remove nonsense <a> for commit status check icon #26287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 3, 2023
Merged

Remove nonsense <a> for commit status check icon #26287

merged 7 commits into from
Aug 3, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Aug 2, 2023

We are using <a> for commit status check icon with no link. So it is clickable but this is no sense.
I think we can convert this to div.
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 2, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 2, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 2, 2023
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 2, 2023
@denyskon denyskon added this to the 1.21.0 milestone Aug 2, 2023
delvh
delvh approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope we didn't break any style selectors with that.

@silverwind silverwind changed the title Remove no sense <a> for commit status check icon Remove nonsense <a> for commit status check icon Aug 2, 2023
@silverwind silverwind merged commit d74c222 into go-gitea:main Aug 3, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 3, 2023
@yp05327 yp05327 deleted the remove-a-of-commit-status branch August 7, 2023 02:28
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 1, 2023
@denyskon denyskon added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@denyskon denyskon denyskon approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yp05327 @silverwind @denyskon @delvh @GiteaBot