Enable RTL support for all inputs and textareas

[silverwind]

Result of

perl -p -i -e 's#<textarea #<textarea dir="auto" #g' templates/**/* web_src/js/**/*.{js,vue}
perl -p -i -e 's#<input #<input dir="auto" #g' templates/**/* web_src/js/**/*.{js,vue}

There are likely a few superflous replacements, we need to review diff carefully.

[silverwind]

I'm inclined to not fix the cases of hidden inputs or comments, just to reinforce that this attribute should always be set.

BTW, this is a prime example why a shared/input template would be good. Change would be 1 line instead of 900+ :)

[yekanchi]

خیلی ممنون.
کارتون عالیه!

[silverwind]

I think I'll actually do a pass and remove it from all inputs where type is hidden,checkbox,file. Any other types I missed?

[silverwind]

Actually it does work on type=file.

I think this is good to go. The extra work to remove the dir attribute on types checkbox and hidden seems not worth it.

[yardenshoham]

נראה מעולה, תודה רבה!

[wxiaoguang]

Haven't read code or thought about it carefully.

But I have a question about whether this approach is good enough: for future PRs, will there always be a person who are able to keep telling contributors "please add dir=auto" again and again?

---

Some more thoughts:

1. Maybe MutationObserver is a good use case for it. Just add "dir=auto" automtically for all input/textarea elements.
2. If it would use "{{template "shared/input ....}}", there must be a lint rule to forbid the <input> in code, and it still has down side: it can't handle backend generated HTML / JS code / Vue component automatically.

[silverwind]

I think best we can do is watch out for these in review. MutationObserver might be something to consider too, yes.

I don't think djilint supports forbiding certain elements, but it'd be a nice feature to have.

[wxiaoguang]

I think best we can do is watch out for these in review. MutationObserver might be something to consider too, yes.

Would you like to take a try? Or I could try too. TBH, keeping asking contributors to add "dir=auto" doesn't look good to me.

[silverwind]

Not interested right now, this PR should be a simple attribute addition.

I will do one pass to remove it from hidden and checkbox just for the sake of it being useless there. That alone is already a lot of work with over 500 matches.

I think it's ideal to be correct without any JS involved.

[wxiaoguang]

Not interested right now, this PR should be a simple attribute addition.

I will try to propose a MutationObserver solution. If there is no performance problem, I think that's the once and for all solution.

[silverwind]

Ready to review/merge now, diff is down to half after hidden/checkbox removal.

[wxiaoguang]

Ready to review/merge now, diff is down to half after hidden/checkbox removal.

Could we wait for more time? I do not think keeping adding attributes manually is maintainable.

[silverwind]

I will try to propose a MutationObserver solution. If there is no performance problem, I think that's the once and for all solution.

Try that I guess. Sadly it means RTL won't work without JS, but it would be the more maintainable solution via JS.

[wxiaoguang]

Sadly it means RTL won't work without JS

Gitea UI already doesn't work without JS for long time.

[silverwind]

Well I blame it on the browser vendors for not making this attribute the default. Maybe they will see the light someday and we can remove the JS then.

[wxiaoguang]

-> Add "dir=auto" for input/textarea elements by default #26735

[silverwind]

#26735 has non-neglible performance impact, I think this solution is better. We don't have to meticulously have dir=auto on every element. For example GitHub only very rarely adds it, like on this Textarea.

[silverwind]

So I think I'm definitely done here, checked the diff twice, it's now down to +399 −398.

[wxiaoguang]

#26735 has been fully rewritten, now it takes around 1.5ms on a PR page with +6966 -3615 (the rendered changed lines is around 3000)

[silverwind]

IDK, maybe we should just do it for the single markup textarea and be done with it, it seems that's exactly what GitHub is doing. Possibly all textareas.

[silverwind]

Closing in favor of #26735