Skip to content

Add release notes for v1.2.0 #2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2017
Merged

Add release notes for v1.2.0 #2683

merged 2 commits into from
Oct 12, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 10, 2017

As titile.

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Oct 10, 2017
@lunny lunny added this to the 1.2.0 milestone Oct 10, 2017
@lafriks
Copy link
Member

lafriks commented Oct 10, 2017

Shouldn't RC changelog be removed as these are duplicate with 1.2.0 final?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 10, 2017
@lunny
Copy link
Member Author

lunny commented Oct 10, 2017

@lafriks I have no idea about that. @tboerger @bkcsoft @appleboy ?

@strk
Copy link
Member

strk commented Oct 10, 2017

+1 for removing RC section and I'd also get rid of the BUGS section as all bug fixes for existing features should go to the stable branch (1.1). This should be only new features and (hopefully none) breaking changes. Please see also #2608 because there's a lot of redundancy in this CHANGELOG

@bkcsoft
Copy link
Member

bkcsoft commented Oct 10, 2017

+1 for removing RC sections

tboerger
tboerger reviewed Oct 10, 2017
View reviewed changes
Copy link
Member

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't like this changelog, it's far too noisy and there are duplicated lines with just gofmt as a title.

Beside that a final release should be merged with the RCs.

CHANGELOG.md Outdated
* feat: Only use issue and wiki on repo. (#1297)
* Allow push to init a wiki repo (#1279)
* Dockerfile for aarch64 (#1128) (#1130)
* SECURITY
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security and breaking changes should be on the top of the list

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

CHANGELOG.md Outdated
* Remove sha1 hash display in repository table (#1678)
* Download files to their original filename (#1676)
* Exposes in API the Repo entity's Size and IsBare property
(#1668)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new line should be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

CHANGELOG.md Outdated
* Check if missing/modified/unused deps in vendor and fix errors (#1468)
* Add GOFLAGS and EXTRA_GOFLAGS (#1438)
* Include formatting check to the `make test` (and thus also `check`) rule (#1366)
* DOCS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A docs section? seriously?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? Or Where should I put this changes? Misc?

CHANGELOG.md Outdated
* add mssql to app.ini db config comment (#1172)
* Add MSSQL to issues template (#1171)
* MISC
* Fix adding branch as protected to not allow pushing to it (#2556)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

CHANGELOG.md Outdated
* Add MSSQL to issues template (#1171)
* MISC
* Fix adding branch as protected to not allow pushing to it (#2556)
* Fix releases to be counted from database not tags (#2389) (#2424)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually only kind of fix and more like feature to be more compatible behaviour people expect from release page of repository and are used to in GitHub

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it still a fix as it fixed problems with release page :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd list this as Tags listed in releases tab (#2389) (#2424) under Misc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were listed also in previous stable release only paging was completely broken and order also I think. They stopped showing up when paging was fixed and so I fixed that back

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tboerger @bkcsoft done.

@lunny
Copy link
Member Author

lunny commented Oct 11, 2017

@lafriks done.

@lunny
Copy link
Member Author

lunny commented Oct 11, 2017

This changelog is generated from PRs according lables on milestone 1.2.0 by github.com/go-gitea/changelog. And I have adjusted them, please review again.

@ptman
Copy link
Contributor

ptman commented Oct 11, 2017

Maybe this is a clear indication that Using commit log diffs as changelogs is a bad idea. It can be useful to use as basis to write the changelog, so that nothing is forgotten. But clearly needs a human touch.

@MCF
Copy link
Contributor

MCF commented Oct 12, 2017

Folks, it doesn't have to be perfect for this release. Can we please just release 1.2.0. And thanks to everyone who has contributed, particularly the core contributors.

@lafriks
Copy link
Member

lafriks commented Oct 12, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 12, 2017
@daviian
Copy link
Member

daviian commented Oct 12, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 12, 2017
@lunny lunny merged commit ed07d8a into go-gitea:release/v1.2 Oct 12, 2017
@lunny lunny deleted the lunny/v1.2_release_notes branch October 12, 2017 06:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tboerger tboerger tboerger left review comments

@lafriks lafriks lafriks left review comments

@bkcsoft bkcsoft bkcsoft left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
8 participants
@lunny @lafriks @strk @bkcsoft @ptman @MCF @daviian @tboerger