Skip to content

Fix repo count in org action settings #27245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Sep 25, 2023

Only in org action settings, repo count is missing

Before:
image
image
image
In other setting page:
image

After:
image
image
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 25, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Sep 25, 2023

Is it possible to move shared_user.LoadHeaderCount into router? 🤔
For example, add a function called PrepareOrgHeaderCount and add it to any related links in router/web/web.go

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 29, 2023
@delvh delvh added type/bug topic/ui Change the appearance of the Gitea UI backport/v1.21 This PR should be backported to Gitea 1.21 labels Sep 29, 2023
@silverwind
Copy link
Member

If there is a org-page handler (didn't check code), I think it'd be preferred to do it once there for all tabs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 29, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 29, 2023
@lunny lunny added this to the 1.22.0 milestone Sep 29, 2023
@github-actions github-actions bot removed the topic/ui Change the appearance of the Gitea UI label Sep 29, 2023
@lunny lunny enabled auto-merge (squash) September 29, 2023 13:54
@lunny lunny merged commit 393193a into go-gitea:main Sep 29, 2023
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Sep 29, 2023
@yp05327 yp05327 deleted the fix-repo-count-in-org-action-settings branch November 6, 2023 00:53
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants