Skip to content

Document the queue item's marshaling behavior #27271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2023
Merged

Document the queue item's marshaling behavior #27271

merged 1 commit into from
Sep 26, 2023

Conversation

wxiaoguang
Copy link
Contributor

Close #26843

//     - Since the item is marshaled by JSON, and JSON doesn't have stable key-order/type support,
//     so the decoded handler item may not be the same as the original "pushed" one if you use map/any types,

@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Sep 26, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Sep 26, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 26, 2023
@wxiaoguang wxiaoguang changed the title Document the queue item's marshaling problem Document the queue item's marshaling behavior Sep 26, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 26, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 26, 2023
@wxiaoguang wxiaoguang merged commit d0012c8 into go-gitea:main Sep 26, 2023
@wxiaoguang wxiaoguang deleted the doc-queue branch September 26, 2023 05:59
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@CaiCandong CaiCandong CaiCandong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Queue unexpected type conversion
4 participants
@wxiaoguang @lunny @CaiCandong @GiteaBot