Skip to content

Fix notifications tabs according to semantic-ui docs #2733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2017
Merged

Fix notifications tabs according to semantic-ui docs #2733

merged 2 commits into from
Oct 18, 2017

Conversation

pgaskin
Copy link
Contributor

@pgaskin pgaskin commented Oct 18, 2017

This removes the line under the active tab, which should not be there. This also makes this comply with the documentation: https://semantic-ui.com/collections/menu.html

notificationstabs

@pgaskin pgaskin changed the title Fix tabs according to semantic-ui docs Fix notifications tabs according to semantic-ui docs Oct 18, 2017
@codecov-io
Copy link

codecov-io commented Oct 18, 2017

Codecov Report

Merging #2733 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2733   +/-   ##
=======================================
  Coverage   26.91%   26.91%           
=======================================
  Files          87       87           
  Lines       17285    17285           
=======================================
  Hits         4652     4652           
  Misses      11954    11954           
  Partials      679      679

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a184f5...1f61362. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 18, 2017
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Oct 18, 2017
@lafriks lafriks added this to the 1.3.0 milestone Oct 18, 2017
@lafriks
Copy link
Member

lafriks commented Oct 18, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 18, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 18, 2017
@lafriks lafriks merged commit 30afce1 into go-gitea:master Oct 18, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants