Skip to content

Fix discord hook bug #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2017
Merged

Fix discord hook bug #2778

merged 1 commit into from
Oct 25, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 25, 2017

No description provided.

@lunny lunny added the type/bug label Oct 25, 2017
@lunny lunny added this to the 1.3.0 milestone Oct 25, 2017
@codecov-io
Copy link

Codecov Report

Merging #2778 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2778   +/-   ##
=======================================
  Coverage   27.08%   27.08%           
=======================================
  Files          88       88           
  Lines       17264    17264           
=======================================
  Hits         4676     4676           
  Misses      11909    11909           
  Partials      679      679
Impacted Files Coverage Δ
models/webhook_discord.go 3.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f04e7...a4566ea. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 25, 2017
@lafriks
Copy link
Member

lafriks commented Oct 25, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 25, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 25, 2017
@lunny lunny merged commit 796be03 into go-gitea:master Oct 25, 2017
@lunny lunny deleted the lunny/fix_discord_webhook branch October 25, 2017 05:14
vdbt pushed a commit to vdbt/gitea that referenced this pull request Oct 27, 2017
@lunny @vdbt
fix discord hook bug (go-gitea#2778)
7fa9678
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @lafriks @ethantkoenig @tboerger