-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
chore: simplify docker build process. #2827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
But will it keep only master branch for |
Codecov Report
@@ Coverage Diff @@
## master #2827 +/- ##
==========================================
+ Coverage 20.22% 20.23% +0.01%
==========================================
Files 145 145
Lines 28997 28997
==========================================
+ Hits 5864 5867 +3
+ Misses 22242 22240 -2
+ Partials 891 890 -1
Continue to review full report at Codecov.
|
@lafriks Yes. it always does that since nobody can't create any branch on Gitea repo expect owner. Every need to fork this project to self-account and create a new branch, then send the PR. |
@lafriks I created new PR to fix your problem. drone-plugins/drone-docker#160 |
@appleboy but there is also release branches that could possibly make latest not to be from master branch |
@lafriks Yes. so I created new PR to fix the condition for multiple branches. |
Would leaving |
@lafriks We don't need to leave |
The docker plugin only builds image when branch equal to default branch of the project and push the tag event. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
.drone.yml
Outdated
tags: [ '${DRONE_TAG##v}' ] | ||
when: | ||
event: [ tag ] | ||
|
||
docker: | ||
image: plugins/docker:17.05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing as the announcement was Oct '17 (17.10) should we have to update this image tag as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. f16eac1
.drone.yml
Outdated
@@ -200,12 +191,10 @@ pipeline: | |||
docker: | |||
image: plugins/docker:17.05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this obviously
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. f16eac1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above review comment should've been a "request change" 🙄
make the bot work |
See the folllowings:
ref: https://discourse.drone.io/t/new-default-tags-parameter-for-docker-plugin/995
cc @lunny @tboerger