Skip to content

Fix commit status in repo list #28412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Dec 11, 2023

Before:
image
image
TestOrg/testactions does have commit status, but won't display in All

After:
image

Same to #26179.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2023
@yp05327 yp05327 force-pushed the fix-list-repo-commit-status branch from 054229d to 0416154 Compare December 11, 2023 00:17
@yp05327
Copy link
Contributor Author

yp05327 commented Dec 11, 2023

ps: Can not understand why SetSessionPagination does not check IsListAll.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2023
@delvh delvh added type/bug topic/ui Change the appearance of the Gitea UI labels Dec 11, 2023
@lunny
Copy link
Member

lunny commented Dec 11, 2023

ps: Can not understand why SetSessionPagination does not check IsListAll.

It's legacy code. I think we need to refacotr all of them.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 11, 2023
@lunny lunny enabled auto-merge (squash) December 11, 2023 05:46
@lunny lunny merged commit 0abb563 into go-gitea:main Dec 11, 2023
@GiteaBot GiteaBot added this to the 1.22.0 milestone Dec 11, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 11, 2023
@yp05327 yp05327 deleted the fix-list-repo-commit-status branch December 11, 2023 06:41
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 11, 2023
* giteaofficial/main:
  Fix commit status in repo list (go-gitea#28412)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants