Skip to content

Golint for models/org_team.go #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2016
Merged

Golint for models/org_team.go #285

merged 2 commits into from
Nov 28, 2016

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 28, 2016

No description provided.

@lunny lunny added this to the 1.0.0 milestone Nov 28, 2016
tboerger
tboerger reviewed Nov 28, 2016
View reviewed changes
models/org_team.go
func (t *Team) IsMember(uid int64) bool {
return IsTeamMember(t.OrgID, t.ID, uid)
// IsMember returns true if given user is a member of team.
func (t *Team) IsMember(uID int64) bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think UID

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or userID

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

userID please :)

@thibaultmeyer
Copy link
Contributor

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 28, 2016
@strk
Copy link
Member

strk commented Nov 28, 2016

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2016
@thibaultmeyer
Copy link
Contributor

LGTM

@tboerger tboerger merged commit 9948f0d into go-gitea:master Nov 28, 2016
@lunny lunny deleted the lunny/golint_models_org_team branch November 28, 2016 09:33
@lunny
Copy link
Member Author

lunny commented Nov 28, 2016

resolved #70

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tboerger tboerger tboerger left review comments

@bkcsoft bkcsoft bkcsoft left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @thibaultmeyer @strk @tboerger @bkcsoft