Project unification, updates for contributors guide and github files #290
Conversation
|
LGTM |
tboerger
added
the
lgtm/need 1
| pull request workflow to do that and use [lgtm](http://lgtm.co) to ensure | ||
| every PR is reviewed by at least 2 maintainers. | ||
|
|
||
| Please try to make your pull request easy to review for us. Please read the |
There was a problem hiding this comment.
I have prepared this file once, and the file i used for that didn't contained that paragraph -.-
There was a problem hiding this comment.
Please add this section, it's very useful.
There was a problem hiding this comment.
Yes I will add it to all the CONTRIBUTING.md files.
There was a problem hiding this comment.
Added it back with 8def53f
| set your `user.name` and `user.email` git configs, you can sign your | ||
| commit automatically with `git commit -s`. | ||
|
|
||
| ## Contributors |
There was a problem hiding this comment.
Because you can't keep this file updated at all. Everybody who does only a single commit to this repo is automatically a contributor. Instead of that file I am linking to the GitHub graph which shows all contributors pretty properly.
There was a problem hiding this comment.
Maybe you are right. But a contributor file will be published with the codes.
There was a problem hiding this comment.
Let's move that to a new issue for a bot or some script that automatically writes a CONTRIBUTORS file, than nobody needs to take care about it.
|
LGTM |
tboerger
added
lgtm/done
|
But I think maybe you should let @bkcsoft review this. |
No description provided.