Skip to content

Remove unnecessary parameter #29092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 8, 2024
Merged

Remove unnecessary parameter #29092

merged 3 commits into from
Feb 8, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 8, 2024

The parameter extraConfigs has never been used anywhere. This PR just removed it. It can be taken back once it's needed.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 8, 2024
@lunny lunny added this to the 1.22.0 milestone Feb 8, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 8, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2024
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 8, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 8, 2024
@lunny lunny enabled auto-merge (squash) February 8, 2024 11:58
@lunny lunny merged commit 8c6ffda into go-gitea:main Feb 8, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 8, 2024
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@lunny @silverwind
Remove unnecessary parameter (go-gitea#29092)
7ed3aef 
The parameter extraConfigs has never been used anywhere. This PR just
removed it. It can be taken back once it's needed.
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
@lunny @earl-warren
[gitea] Remove unnecessary parameter (go-gitea#29092)
1fdd834 
The parameter extraConfigs has never been used anywhere. This PR just
removed it. It can be taken back once it's needed.

(cherry picked from commit 8c6ffda)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
@lunny lunny deleted the lunny/remove_unnecessary_parameter branch March 5, 2024 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @silverwind @wxiaoguang @delvh @GiteaBot