Reference labels by IDs instead of names in keys settings
#29194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's the spec for the `for` attribute: https://html.spec.whatwg.org/multipage/forms.html#attr-label-for Signed-off-by: Yarden Shoham <[email protected]>
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
the
modifies/templates
delvh
added
type/bug
topic/accessibility
delvh
approved these changes
Feb 16, 2024
GiteaBot
added
lgtm/need 1
delvh
changed the title
keys settings
wxiaoguang
approved these changes
Feb 16, 2024
GiteaBot
added
lgtm/done
silverwind
approved these changes
Feb 16, 2024
silverwind
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.21. @yardenshoham, please send one manually. 🍵 |
GiteaBot
added
backport/manual
yardenshoham
removed
backport/manual
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 16, 2024
* giteaofficial/main: Reference labels by IDs instead of names in `keys` settings (go-gitea#29194)
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
…#29194) Here's the spec for the `for` attribute: https://html.spec.whatwg.org/multipage/forms.html#attr-label-for Signed-off-by: Yarden Shoham <[email protected]>
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
…#29194) Here's the spec for the `for` attribute: https://html.spec.whatwg.org/multipage/forms.html#attr-label-for Signed-off-by: Yarden Shoham <[email protected]> (cherry picked from commit 7132a0b)
|
Automatically locked because of our CONTRIBUTING guidelines |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the spec for the
forattribute: https://html.spec.whatwg.org/multipage/forms.html#attr-label-for