Skip to content

Remove jQuery from organization rename prompt toggle #29195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Remove jQuery from organization rename prompt toggle #29195

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f6cd9c4
Remove jQuery from organization rename prompt toggle
yardenshoham Feb 16, 2024
6bedd57
Fix if
yardenshoham Feb 16, 2024
08b21e8
Remove redundant `if`
yardenshoham Feb 16, 2024
b7dcec6
Revert "Remove redundant `if`"
yardenshoham Feb 16, 2024
bec757b
Update web_src/js/features/common-organization.js
yardenshoham Feb 16, 2024
fd92e09
Merge branch 'main' into common-organization-jquery
yardenshoham Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions web_src/js/features/common-organization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import $ from 'jquery';
import {initCompLabelEdit} from './comp/LabelEdit.js';
import {toggleElem} from '../utils/dom.js';

export function initCommonOrganization() {
if ($('.organization').length === 0) {
if (!document.querySelectorAll('.organization').length) {
return;
}

$('.organization.settings.options #org_name').on('input', function () {
const nameChanged = $(this).val().toLowerCase() !== $(this).attr('data-org-name').toLowerCase();
const orgNameInput = document.querySelector('.organization.settings.options #org_name');
if (!orgNameInput) return;
Comment on lines +9 to +10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait .... it seem incorrect .....

There is another call initCompLabelEdit below. It shouldn't return here.

So the old logic (like if ($('.organization').length === 0) { ) is still needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, reverting.

orgNameInput.addEventListener('input', function () {
const nameChanged = this.value.toLowerCase() !== this.getAttribute('data-org-name').toLowerCase();
toggleElem('#org-name-change-prompt', nameChanged);
});

Expand Down