Skip to content

Fix govendor for x/crypto curve25519 #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2017
Merged

Fix govendor for x/crypto curve25519 #2925

merged 2 commits into from
Nov 17, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Nov 16, 2017

Fixes build on non amd64 arhitecture

@lafriks lafriks added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels Nov 16, 2017
@lafriks lafriks added this to the 1.3.0 milestone Nov 16, 2017
@lafriks lafriks force-pushed the fix/vendor_remove_appengine_ignore branch from 67c6635 to d2a24a7 Compare November 16, 2017 09:24
@lafriks lafriks changed the title Do not ignore appengine tag in govendor Fix govendor for x/crupto curve25519 Nov 16, 2017
@lafriks lafriks changed the title Fix govendor for x/crupto curve25519 Fix govendor for x/crypto curve25519 Nov 16, 2017
@codecov-io
Copy link

codecov-io commented Nov 16, 2017 •
edited
Loading

Codecov Report

Merging #2925 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2925      +/-   ##
==========================================
- Coverage   27.26%   27.24%   -0.02%     
==========================================
  Files          89       89              
  Lines       17640    17640              
==========================================
- Hits         4809     4806       -3     
- Misses      12144    12146       +2     
- Partials      687      688       +1
Impacted Files Coverage Δ
modules/process/manager.go 69.56% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33ce46...648a666. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 16, 2017
@lunny
Copy link
Member

lunny commented Nov 16, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 16, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2017
@lunny lunny merged commit b23cf16 into go-gitea:master Nov 17, 2017
@lafriks lafriks modified the milestones: 1.3.0, 1.4.0 Nov 20, 2017
@lafriks lafriks deleted the fix/vendor_remove_appengine_ignore branch November 20, 2017 23:45
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Nov 20, 2017
@lafriks
Fix govendor for x/crupto curve25519 (go-gitea#2925)
07871b9
@lafriks lafriks modified the milestones: 1.4.0, 1.3.0 Nov 20, 2017
@lafriks lafriks mentioned this pull request Nov 20, 2017
Merged
lafriks added a commit that referenced this pull request Nov 21, 2017
@lafriks
Update golang x/crypto dependencies (#2923) (#2951)
be41955 
* Update golang x/crypto dependencies (#2923)

* Fix govendor for x/crupto curve25519 (#2925)
@lafriks lafriks added the backport/done All backports for this PR have been created label Nov 23, 2017
@lafriks lafriks modified the milestones: 1.3.0, 1.4.0 Nov 27, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @codecov-io @lunny @ethantkoenig @tboerger