Skip to content

Move context from modules to services #29440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2024
Merged

Move context from modules to services #29440

merged 1 commit into from
Feb 27, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 27, 2024 •
edited
Loading

Since modules/context has to depend on models and many other packages, it should be moved from modules/context to services/context according to design principles. There is no logic code change on this PR, only move packages.

  • Move code.gitea.io/gitea/modules/context to code.gitea.io/gitea/services/context
  • Move code.gitea.io/gitea/modules/contexttest to code.gitea.io/gitea/services/contexttest because of depending on context
  • Move code.gitea.io/gitea/modules/upload to code.gitea.io/gitea/services/context/upload because of depending on context

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 27, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 27, 2024
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Feb 27, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 27, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2024
@6543 6543 merged commit 29f149b into go-gitea:main Feb 27, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 27, 2024
@lunny lunny deleted the lunny/move_context_services branch February 27, 2024 07:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wolfogre wolfogre wolfogre approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @wolfogre @6543 @GiteaBot