Skip to content

Fix bench deps since #2916 #2971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2017
Merged

Fix bench deps since #2916 #2971

merged 2 commits into from
Nov 26, 2017

Conversation

sapk
Copy link
Member

@sapk sapk commented Nov 25, 2017 •
edited
Loading

PR #2916 merge rules for tests integration and bench is based on them.

@codecov-io
Copy link

codecov-io commented Nov 25, 2017 •
edited
Loading

Codecov Report

Merging #2971 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2971      +/-   ##
==========================================
+ Coverage    26.8%   26.82%   +0.01%     
==========================================
  Files          90       90              
  Lines       17807    17807              
==========================================
+ Hits         4774     4777       +3     
+ Misses      12353    12351       -2     
+ Partials      680      679       -1
Impacted Files Coverage Δ
modules/process/manager.go 73.91% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40c545d...e2d831f. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 25, 2017
@lafriks
Copy link
Member

lafriks commented Nov 25, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 25, 2017
@lafriks lafriks added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Nov 25, 2017
@lafriks lafriks added this to the 1.4.0 milestone Nov 25, 2017
@lunny
Copy link
Member

lunny commented Nov 26, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 26, 2017
@lunny lunny merged commit d23a3e9 into go-gitea:master Nov 26, 2017
@sapk sapk deleted the fix-bench-deps branch December 9, 2017 21:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tonivj5 tonivj5 tonivj5 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sapk @codecov-io @lafriks @lunny @tonivj5 @tboerger