-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Fix coverage reports #2974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coverage reports #2974
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2974 +/- ##
==========================================
+ Coverage 26.8% 32.49% +5.68%
==========================================
Files 90 267 +177
Lines 17810 39270 +21460
==========================================
+ Hits 4774 12760 +7986
- Misses 12355 24718 +12363
- Partials 681 1792 +1111
Continue to review full report at Codecov.
|
e66ee76
to
83c9a83
Compare
LGTM |
LGTM |
Make LG-TM work |
@lafriks Why do you comment "Make LG-TM work" on PRs that already have the |
@ethantkoenig because when you update branch to latest master github loses status checks, so commenting anything makes LG-TM update status for latest commit that is now merge commit. Otherwise GitHub does not allow to merge it as there are no all needed checks passed |
I see, that makes sense |
The previous
egrep
regex was wrong, so no coverage information from integration tests was included incoverage.all
.Also simplifies the
make coverage
rule by removing an unnecessary loop.