Skip to content

Fix coverage reports #2974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 26, 2017
Merged

Fix coverage reports #2974

merged 6 commits into from
Nov 26, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Nov 26, 2017

The previous egrep regex was wrong, so no coverage information from integration tests was included in coverage.all.

Also simplifies the make coverage rule by removing an unnecessary loop.

@codecov-io
Copy link

codecov-io commented Nov 26, 2017

Codecov Report

Merging #2974 into master will increase coverage by 5.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2974      +/-   ##
==========================================
+ Coverage    26.8%   32.49%   +5.68%     
==========================================
  Files          90      267     +177     
  Lines       17810    39270   +21460     
==========================================
+ Hits         4774    12760    +7986     
- Misses      12355    24718   +12363     
- Partials      681     1792    +1111
Impacted Files Coverage Δ
models/migrations/v24.go 0% <0%> (ø)
cmd/web.go 0% <0%> (ø)
models/migrations/v15.go 0% <0%> (ø)
models/migrations/v30.go 0% <0%> (ø)
modules/cache/cache.go 31.25% <0%> (ø)
modules/util/compare.go 28.57% <0%> (ø)
cmd/web_graceful.go 0% <0%> (ø)
modules/minwinsvc/minwinsvc.go 0% <0%> (ø)
routers/repo/issue.go 35.37% <0%> (ø)
modules/log/xorm.go 29.57% <0%> (ø)
... and 223 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d85c1d...6ec2541. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 26, 2017
@lafriks
Copy link
Member

lafriks commented Nov 26, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 26, 2017
@lunny lunny added this to the 1.4.0 milestone Nov 26, 2017
@lunny
Copy link
Member

lunny commented Nov 26, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 26, 2017
@lafriks
Copy link
Member

lafriks commented Nov 26, 2017

Make LG-TM work

@ethantkoenig
Copy link
Member Author

ethantkoenig commented Nov 26, 2017

@lafriks Why do you comment "Make LG-TM work" on PRs that already have the lgtm/done label?

@lafriks
Copy link
Member

lafriks commented Nov 26, 2017

@ethantkoenig because when you update branch to latest master github loses status checks, so commenting anything makes LG-TM update status for latest commit that is now merge commit. Otherwise GitHub does not allow to merge it as there are no all needed checks passed

@ethantkoenig
Copy link
Member Author

I see, that makes sense

@lafriks lafriks merged commit f148a4a into go-gitea:master Nov 26, 2017
@ethantkoenig ethantkoenig deleted the fix/coverage branch December 18, 2017 06:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants