-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Don't print SQL in unit tests #2995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2995 +/- ##
==========================================
- Coverage 32.54% 32.53% -0.02%
==========================================
Files 267 267
Lines 39270 39271 +1
==========================================
- Hits 12779 12775 -4
- Misses 24698 24702 +4
- Partials 1793 1794 +1
Continue to review full report at Codecov.
|
LGTM |
LGTM |
How about add an environment to enable that? Sometimes we need to know where is the error. |
@lunny Done |
44c5714
to
2ad8f5d
Compare
Currently, all SQL commands, from all tests, are printed to stdout (or maybe stderr?) when a unit test fails. This is too much output (thousands of lines) to be helpful as the default; you have to scroll through a bunch of unrelated output just to see which test failed.
Now, output will only be printed if the environment variable
$GITEA_UNIT_TESTS_VERBOSE
is set to true.