Skip to content

Use unique name for docs docker build step in CI #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2017
Merged

Use unique name for docs docker build step in CI #3018

merged 2 commits into from
Nov 29, 2017

Conversation

techknowlogick
Copy link
Member

Otherwise drone may combine (or hide) the logs for the docs image

Otherwise drone may combine the logs
@lafriks
Copy link
Member

lafriks commented Nov 28, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 28, 2017
@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Nov 28, 2017
@codecov-io
Copy link

codecov-io commented Nov 28, 2017

Codecov Report

Merging #3018 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3018      +/-   ##
==========================================
+ Coverage   32.98%   33.01%   +0.02%     
==========================================
  Files         270      270              
  Lines       39534    39534              
==========================================
+ Hits        13042    13052      +10     
+ Misses      24637    24631       -6     
+ Partials     1855     1851       -4
Impacted Files Coverage Δ
models/repo.go 38% <0%> (+0.18%) ⬆️
models/repo_indexer.go 49% <0%> (+3.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab2b35...f03f6b3. Read the comment docs.

@lunny
Copy link
Member

lunny commented Nov 29, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2017
@lafriks lafriks merged commit 899c900 into go-gitea:master Nov 29, 2017
@lunny lunny added this to the 1.4.0 milestone Nov 29, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants