Memory usage improvements and lower minimal git requirement to 1.7.2 (#3013) #3028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* govendor update code.gitea.io/git Signed-off-by: Duncan Ogilvie <[email protected]> * Greatly improve memory usage Signed-off-by: Duncan Ogilvie <[email protected]>
|
LGTM |
tboerger
added
the
lgtm/need 1
|
When I see https://github.com/go-gitea/git/pull/90/files, I think this is unnecessary. There are some risk to send an enhancement PR back port to 1.3. |
|
We only need the change on - GitVersionRequired = "1.8.1.6"
+ GitVersionRequired = "1.7.2" |
|
Those additional files are just tests (and CI/drone) related. Where's the risk you see ? |
|
@lunny there is either all or nothing here :) |
|
oh, Yes. LGTM |
tboerger
added
lgtm/done
|
make L-G-T-M work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to 1.3