Skip to content

Fixtures for public_key table #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2017
Merged

Conversation

ethantkoenig
Copy link
Member

TestAPIAdminCreateAndDeleteSSHKey is failing for me locally, because keys created in previous test runs are not deleted.

@lafriks
Copy link
Member

lafriks commented Dec 10, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 10, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 10, 2017
@codecov-io
Copy link

Codecov Report

Merging #3140 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3140      +/-   ##
==========================================
- Coverage   34.85%   34.83%   -0.02%     
==========================================
  Files         275      275              
  Lines       40030    40030              
==========================================
- Hits        13951    13944       -7     
- Misses      24084    24089       +5     
- Partials     1995     1997       +2
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/ssh_key.go 31.92% <0%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1efe20...d869598. Read the comment docs.

@lunny
Copy link
Member

lunny commented Dec 11, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2017
@lunny lunny merged commit defc97a into go-gitea:master Dec 11, 2017
@ethantkoenig ethantkoenig deleted the public_key_fixtures branch December 18, 2017 06:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants