Skip to content

Fix integration tests #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Conversation

ethantkoenig
Copy link
Member

Delete the local repo copy path between integration tests. If we do not do this, the local copy of a repo created in one test will persist in later tests, which can cause tests to break (see https://drone.gitea.io/go-gitea/gitea/2502/9, which failed because of a leftover local copy of a repo created in git_test.go)

@lafriks lafriks added this to the 1.4.0 milestone Dec 10, 2017
@lafriks
Copy link
Member

lafriks commented Dec 10, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 10, 2017
@sapk
Copy link
Member

sapk commented Dec 10, 2017

LGTM. Sorry for introducing it.

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 10, 2017
@codecov-io
Copy link

Codecov Report

Merging #3141 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3141      +/-   ##
==========================================
+ Coverage   34.83%   34.84%   +0.01%     
==========================================
  Files         275      275              
  Lines       40028    40030       +2     
==========================================
+ Hits        13945    13950       +5     
+ Misses      24085    24084       -1     
+ Partials     1998     1996       -2
Impacted Files Coverage Δ
models/repo.go 41.36% <100%> (-0.12%) ⬇️
models/repo_branch.go 58.73% <0%> (+0.79%) ⬆️
models/repo_indexer.go 50.97% <0%> (+1.45%) ⬆️
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d6afe...10c679d. Read the comment docs.

@appleboy appleboy merged commit d1efe20 into go-gitea:master Dec 11, 2017
@lunny
Copy link
Member

lunny commented Dec 11, 2017

fixed #3128

@ethantkoenig ethantkoenig deleted the fix/integration_tests branch December 18, 2017 06:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants