Skip to content

Move build without gcc step up otherwise it's binary is used in docker #3147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Dec 11, 2017

Fixes docker image that currently is using wrong binary and is completely broken

@lafriks lafriks added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels Dec 11, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 11, 2017
@Bwko
Copy link
Member

Bwko commented Dec 11, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 11, 2017
@codecov-io
Copy link

Codecov Report

Merging #3147 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3147      +/-   ##
==========================================
- Coverage   34.77%   34.53%   -0.24%     
==========================================
  Files         276      276              
  Lines       39945    39945              
==========================================
- Hits        13890    13797      -93     
- Misses      24058    24169     +111     
+ Partials     1997     1979      -18
Impacted Files Coverage Δ
modules/lfs/content_store.go 7.81% <0%> (-35.94%) ⬇️
modules/avatar/avatar.go 81.25% <0%> (-18.75%) ⬇️
modules/lfs/server.go 20.68% <0%> (-14.33%) ⬇️
modules/indexer/repo.go 60.86% <0%> (-6.96%) ⬇️
models/lfs.go 26.08% <0%> (-2.18%) ⬇️
models/repo_indexer.go 50.97% <0%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9563548...faaa86d. Read the comment docs.

@bkcsoft
Copy link
Member

bkcsoft commented Dec 11, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2017
@bkcsoft bkcsoft merged commit b82519c into go-gitea:master Dec 11, 2017
@lafriks lafriks deleted the fix/docker_build branch December 11, 2017 10:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants