Skip to content

Fix wiki page list not rendering after UpdatedUnix changes #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2017
Merged

Fix wiki page list not rendering after UpdatedUnix changes #3175

merged 2 commits into from
Dec 13, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Dec 12, 2017

Was broken after #3142 changes

@lafriks lafriks added this to the 1.4.0 milestone Dec 12, 2017
@codecov-io
Copy link

codecov-io commented Dec 12, 2017 •
edited
Loading

Codecov Report

Merging #3175 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3175      +/-   ##
==========================================
+ Coverage    34.7%   34.72%   +0.02%     
==========================================
  Files         276      276              
  Lines       39970    39970              
==========================================
+ Hits        13871    13881      +10     
+ Misses      24102    24095       -7     
+ Partials     1997     1994       -3
Impacted Files Coverage Δ
routers/repo/wiki.go 44.4% <100%> (ø) ⬆️
models/repo.go 41.47% <0%> (+0.18%) ⬆️
models/repo_indexer.go 51.94% <0%> (+0.97%) ⬆️
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00bfa1d...e920f02. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 12, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 13, 2017
@lunny
Copy link
Member

lunny commented Dec 13, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 13, 2017
@lunny
Copy link
Member

lunny commented Dec 13, 2017

will fix #3184

@lunny lunny mentioned this pull request Dec 13, 2017
Closed
5 tasks
@lunny lunny merged commit d3c5911 into go-gitea:master Dec 13, 2017
@lafriks lafriks deleted the fix/creating_wiki_updateunix branch December 13, 2017 14:52
@WallenHan
Copy link

when release this fixed version? in 1.4.0 ?

@lunny
Copy link
Member

lunny commented Dec 19, 2017

@WallenHan this will be master and not affect v1.3.x and should be in v1.4.0

@WallenHan
Copy link

@lunny is there a bugfixed version now? I am using the docker gitea.

@lunny
Copy link
Member

lunny commented Dec 20, 2017

docker pull gitea/gitea:latest upgrade to latest version will resolve your problem.

@WallenHan
Copy link

WallenHan commented Dec 20, 2017 •
edited
Loading

thank you, give you full score! 💯

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lafriks @codecov-io @ethantkoenig @lunny @WallenHan @tboerger