Skip to content

Resolved #296 #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2016
Merged

Resolved #296 #324

merged 2 commits into from
Dec 1, 2016

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 1, 2016

No description provided.

@lunny lunny added the type/bug label Dec 1, 2016
@lunny lunny added this to the 1.0.0 milestone Dec 1, 2016
Copy link
Member

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking about the template indentation, otherwise LGTM

@@ -24,6 +24,8 @@
</div>
</div>
</div>
{{else}}
<div>{{$.i18n.Tr "explore.org_no_results"}}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

@@ -19,5 +19,9 @@
{{if .DescriptionHTML}}<p class="has-emoji">{{.DescriptionHTML}}</p>{{end}}
<p class="time">{{$.i18n.Tr "org.repo_updated"}} {{TimeSince .Updated $.i18n.Lang}}</p>
</div>
{{else}}
<div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

@@ -24,6 +24,8 @@
</div>
</div>
</div>
{{else}}
<div>{{$.i18n.Tr "explore.user_no_results"}}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@bkcsoft
Copy link
Member

bkcsoft commented Dec 1, 2016

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 1, 2016
@tboerger
Copy link
Member

tboerger commented Dec 1, 2016

I will still give you my LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 1, 2016
@lunny lunny merged commit 590a79f into go-gitea:master Dec 1, 2016
@lunny lunny deleted the lunny/fixed_296 branch December 1, 2016 10:53
@strk
Copy link
Member

strk commented Dec 2, 2016

Please make PR titles meaningful, so those of us receiving notifications by mail can tell what it is about w/out having to open a referenced ticket to know. (and I think it'll also help with automating Changelog if we take the GitLab path)

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants