-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Resolved #296 #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved #296 #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicking about the template indentation, otherwise LGTM
@@ -24,6 +24,8 @@ | |||
</div> | |||
</div> | |||
</div> | |||
{{else}} | |||
<div>{{$.i18n.Tr "explore.org_no_results"}}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation
@@ -19,5 +19,9 @@ | |||
{{if .DescriptionHTML}}<p class="has-emoji">{{.DescriptionHTML}}</p>{{end}} | |||
<p class="time">{{$.i18n.Tr "org.repo_updated"}} {{TimeSince .Updated $.i18n.Lang}}</p> | |||
</div> | |||
{{else}} | |||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation
@@ -24,6 +24,8 @@ | |||
</div> | |||
</div> | |||
</div> | |||
{{else}} | |||
<div>{{$.i18n.Tr "explore.user_no_results"}}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
LGTM |
I will still give you my LGTM |
Please make PR titles meaningful, so those of us receiving notifications by mail can tell what it is about w/out having to open a referenced ticket to know. (and I think it'll also help with automating Changelog if we take the GitLab path) |
No description provided.