Skip to content

MS AD Search Attributes English translation fix #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2018
Merged

MS AD Search Attributes English translation fix #3282

merged 1 commit into from
Jan 2, 2018

Conversation

0rzech
Copy link
Contributor

@0rzech 0rzech commented Jan 2, 2018

Fixes incorrect abbreviation and clarifies it.

@codecov-io
Copy link

Codecov Report

Merging #3282 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3282      +/-   ##
==========================================
- Coverage   34.82%   34.62%   -0.21%     
==========================================
  Files         277      277              
  Lines       40263    40263              
==========================================
- Hits        14021    13940      -81     
- Misses      24183    24279      +96     
+ Partials     2059     2044      -15
Impacted Files Coverage Δ
modules/lfs/content_store.go 7.81% <0%> (-35.94%) ⬇️
modules/lfs/server.go 20.68% <0%> (-14.33%) ⬇️
models/lfs.go 26.08% <0%> (-2.18%) ⬇️
models/repo_indexer.go 50.97% <0%> (-0.98%) ⬇️
models/repo.go 43.2% <0%> (-0.19%) ⬇️
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 289cd1c...d5b7358. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 2, 2018
@lunny
Copy link
Member

lunny commented Jan 2, 2018

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 2, 2018
@lunny lunny added this to the 1.4.0 milestone Jan 2, 2018
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Jan 2, 2018
@appleboy
Copy link
Member

appleboy commented Jan 2, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 2, 2018
@appleboy appleboy merged commit 50b7ba1 into go-gitea:master Jan 2, 2018
@0rzech 0rzech deleted the ms-ad-sa-translation-fix branch February 6, 2018 02:27
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants