Skip to content

Update stylelint config #33419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 28, 2025
Merged

Update stylelint config #33419

merged 9 commits into from
Jan 28, 2025

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jan 27, 2025 •
edited
Loading

  • Inherit stylelint config from stylelint-config-recommended, removed all stylelint core rule options that were either already in their config or disabled.
  • no-descending-specificity diverges from their config, seems to much work currently.
  • Tweaked a few rules.
  • Added stylelint-define-config so that typescript can validate the config.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 27, 2025
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 27, 2025
@silverwind silverwind changed the title Add stylelint-config-recommended and consolidate rules Update stylelint config Jan 27, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 27, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 28, 2025
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Jan 28, 2025
@lunny lunny enabled auto-merge (squash) January 28, 2025 02:28
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Jan 28, 2025
@lunny lunny merged commit 8f43313 into go-gitea:main Jan 28, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 28, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 28, 2025
@silverwind silverwind deleted the styleconf branch January 28, 2025 09:24
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/frontend modifies/internal skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @lunny @delvh @GiteaBot