Skip to content

Remove hardcoded paths to fix randomly failing tests #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jan 10, 2018

  • Adds option for LOCAL_WIKI_PATH so that it would not be hardcoded
  • Reuse local repository path when merging

@lafriks lafriks added type/enhancement An improvement of existing functionality type/testing labels Jan 10, 2018
@lafriks lafriks added this to the 1.4.0 milestone Jan 10, 2018
@codecov-io
Copy link

Codecov Report

Merging #3347 into master will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3347      +/-   ##
==========================================
- Coverage   35.04%   35.03%   -0.02%     
==========================================
  Files         280      280              
  Lines       40566    40571       +5     
==========================================
- Hits        14217    14214       -3     
- Misses      24246    24251       +5     
- Partials     2103     2106       +3
Impacted Files Coverage Δ
modules/setting/setting.go 47.44% <ø> (ø) ⬆️
models/pull.go 51.87% <100%> (ø) ⬆️
models/wiki.go 62.5% <50%> (-0.81%) ⬇️
models/repo_indexer.go 52.91% <0%> (-0.98%) ⬇️
models/repo.go 43.19% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8dff30...31eff33. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 10, 2018
@strk
Copy link
Member

strk commented Jan 10, 2018

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 10, 2018
@bkcsoft
Copy link
Member

bkcsoft commented Jan 10, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 10, 2018
@bkcsoft bkcsoft merged commit be1330e into go-gitea:master Jan 10, 2018
@lafriks lafriks deleted the fix/random_failing_tests branch January 11, 2018 07:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants