Skip to content

Address issues pointed out by @lunny in #3339 #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2018
Merged

Address issues pointed out by @lunny in #3339 #3352

merged 2 commits into from
Jan 12, 2018

Conversation

thehowl
Copy link
Contributor

@thehowl thehowl commented Jan 11, 2018

as title

@codecov-io
Copy link

codecov-io commented Jan 11, 2018

Codecov Report

Merging #3352 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3352      +/-   ##
==========================================
- Coverage   35.05%   35.04%   -0.02%     
==========================================
  Files         280      280              
  Lines       40567    40565       -2     
==========================================
- Hits        14221    14216       -5     
- Misses      24242    24244       +2     
- Partials     2104     2105       +1
Impacted Files Coverage Δ
routers/org/org.go 7.31% <0%> (+0.34%) ⬆️
modules/indexer/indexer.go 70% <0%> (-7.5%) ⬇️
models/repo_indexer.go 51.45% <0%> (-2.43%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51a18f7...f18f47a. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 11, 2018
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 11, 2018
@lafriks lafriks added this to the 1.4.0 milestone Jan 11, 2018
@lunny
Copy link
Member

lunny commented Jan 12, 2018

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 12, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 12, 2018
@lunny lunny merged commit eb0f166 into go-gitea:master Jan 12, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants