Skip to content

Avoid duplicate SetContextValue call #33564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

wxiaoguang
Copy link
Contributor

And fix FIXME and TODO

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 12, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Feb 12, 2025
@wxiaoguang wxiaoguang added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Feb 12, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 12, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 12, 2025
@wxiaoguang wxiaoguang merged commit f58f5bb into go-gitea:main Feb 12, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Feb 12, 2025
@wxiaoguang wxiaoguang deleted the fix-fixme branch February 12, 2025 06:25
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 13, 2025
* giteaofficial/main:
  Only show the latest version in the Arch index (go-gitea#33262)
  [skip ci] Updated translations via Crowdin
  Enable eslint for commonjs (go-gitea#33575)
  Fix various problems (artifact order, api empty slice, assignee check, fuzzy prompt, mirror proxy, adopt git) (go-gitea#33569)
  Switch to `@vitest/eslint-plugin` (go-gitea#33573)
  Avoid duplicate SetContextValue call (go-gitea#33564)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants