Skip to content

add changelog for 1.4.0 #3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 31, 2018
Merged

add changelog for 1.4.0 #3435

merged 6 commits into from
Jan 31, 2018

Conversation

thehowl
Copy link
Contributor

@thehowl thehowl commented Jan 30, 2018

mostly generated straight out of the tool, but removed all refactoring and testing PRs. also added link to the blog on top.

@strk
Copy link
Member

strk commented Jan 30, 2018

ouch it's huge, I liked the blog post version much more, too much information becomes noise (which tool, btw?)

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 30, 2018
@lafriks
Copy link
Member

lafriks commented Jan 30, 2018

Docs should probably be removed

@thehowl
Copy link
Contributor Author

thehowl commented Jan 30, 2018

@strk https://github.com/lunny/changelog

As for the fact that it's huge - I agree. I'm now trying to further cut some some more entries. I quite agree with you in saying that the other changelogs should be more descriptive and shorter, but I also see the point in keeping it "technical" and without hiding too much of what has been changed (for instance, one might not find that we've fixed that very specific bug in the blog post, but they can do so in the CHANGELOG file).

@lafriks I agree, they're not that important. Done.

@lafriks lafriks added this to the 1.4.0 milestone Jan 30, 2018
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Jan 30, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 30, 2018
@codecov-io
Copy link

codecov-io commented Jan 30, 2018

Codecov Report

Merging #3435 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3435      +/-   ##
==========================================
- Coverage   35.62%   35.59%   -0.03%     
==========================================
  Files         281      281              
  Lines       40586    40586              
==========================================
- Hits        14458    14446      -12     
- Misses      23993    24001       +8     
- Partials     2135     2139       +4
Impacted Files Coverage Δ
modules/indexer/indexer.go 70% <0%> (-7.5%) ⬇️
models/repo_indexer.go 44.24% <0%> (-4.43%) ⬇️
models/repo_list.go 65.62% <0%> (-1.57%) ⬇️
models/repo.go 43.17% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a5cc4...fc007b7. Read the comment docs.

without substantial changes to our git log; to see the highlights of what has
been added to each release, please refer to the [blog](https://blog.gitea.io).

## [1.4.0-rc1](https://github.com/go-gitea/gitea/releases/tag/v1.4.0-rc1) - 2018-01-31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously we did not do that

CHANGELOG.md Outdated
* Update gitgraph.js to fix blurry commit graph on HiDPI screens (#2957)
* Fix language names (#2955)
* Remove render issue link (#2954)
* Git LFS lock api (#2938)
Copy link
Member

@sapk sapk Jan 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be in features as it permit to use the command git lfs lock.

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 31, 2018
@lafriks lafriks added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Jan 31, 2018
@lafriks
Copy link
Member

lafriks commented Jan 31, 2018

Waiting for Swedish translation to be approved

@lafriks lafriks removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Jan 31, 2018
@lafriks lafriks merged commit 10171b7 into go-gitea:master Jan 31, 2018
@thehowl thehowl deleted the 1.4.0-changelog branch April 22, 2018 20:02
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants