Fix for #320 #345
Merged
Fix for #320 #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppress the error when we're removing a file that may not exist
|
LGTM |
tboerger
added
the
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
|
Merged. Remember that in some situations makes sense to print to log or create a notice (there's a notice table on DB). Where the file often doesn't exist it is OK to ignore. |
|
To gather more errors and to make errcheck happy we added that, but in this case it fails unintentionally |
|
We should probably use |
|
I think suppressing these 2 errors is the best solution. Since 90% of the time os.remove will fail and we don't want to flood the log with |
|
Aah right, nvm then. I didn't read the comments above the commands 😛 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress the error when we're removing a file that may not exist