Skip to content

Fix migration pull request title too long #34577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 2, 2025

Fix #34294

@lunny lunny added type/bug backport/v1.24 This PR should be backported to Gitea 1.24 labels Jun 2, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 2, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 2, 2025
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess it's okay as a short-term solution. Ideally we should find out maximum pull/issue title length on GitHub and adjust our models to match in a migration.

@silverwind
Copy link
Member

According to https://github.com/dead-claudia/github-limits#issue-title, limit is 256 chars, so just 1 char short of the current 255 limit. Not sure regarding multi-byte unicode, should be tested.

@hiifong
Copy link
Member

hiifong commented Jun 3, 2025

It seems that the length limit of GitHub PR title is more than 256 characters.

ref:hiifong/test#3

image

@lunny
Copy link
Member Author

lunny commented Jun 4, 2025

It seems that the length limit of GitHub PR title is more than 256 characters.

ref:hiifong/test#3

image

Yes. This is a quick patch so that it can be backport to v1.24

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 4, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 4, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) June 4, 2025 15:18
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 4, 2025
@techknowlogick techknowlogick merged commit 497b83b into go-gitea:main Jun 4, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jun 4, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 4, 2025
@lunny lunny deleted the lunny/fix_migrate_bug branch June 4, 2025 16:40
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 4, 2025
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jun 4, 2025
techknowlogick pushed a commit that referenced this pull request Jun 4, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 5, 2025
* giteaofficial/main:
  Fix possible pull request broken when leave the page immediately after clicking the update button (go-gitea#34509)
  Fix migration pull request title too long (go-gitea#34577)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GithHub repo migration failing
5 participants