-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix migration pull request title too long #34577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess it's okay as a short-term solution. Ideally we should find out maximum pull/issue title length on GitHub and adjust our models to match in a migration.
According to https://github.com/dead-claudia/github-limits#issue-title, limit is 256 chars, so just 1 char short of the current 255 limit. Not sure regarding multi-byte unicode, should be tested. |
It seems that the length limit of GitHub PR title is more than 256 characters. ref:hiifong/test#3 |
Yes. This is a quick patch so that it can be backport to v1.24 |
Backport #34577 by @lunny Fix #34294 Co-authored-by: Lunny Xiao <[email protected]>
* giteaofficial/main: Fix possible pull request broken when leave the page immediately after clicking the update button (go-gitea#34509) Fix migration pull request title too long (go-gitea#34577)
Fix #34294