Skip to content

Only activity tab needs heatmap data loading #34652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 9, 2025
Merged

Only activity tab needs heatmap data loading #34652

merged 5 commits into from
Jun 9, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 8, 2025

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 8, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 8, 2025
@lunny lunny added performance/speed performance issues with slow downs and removed modifies/go Pull requests that update Go code labels Jun 8, 2025
@lunny lunny added this to the 1.25.0 milestone Jun 8, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 8, 2025
@techknowlogick techknowlogick added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. backport/v1.24 This PR should be backported to Gitea 1.24 and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 8, 2025
@wxiaoguang
Copy link
Contributor

I think Refactor FindOrgOptions to use enum instead of bool, fix membership visibility #34629 should be merged before this one because that one came first and they conflict.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 9, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 9, 2025
@lunny
Copy link
Member Author

lunny commented Jun 9, 2025

I think Refactor FindOrgOptions to use enum instead of bool, fix membership visibility #34629 should be merged before this one because that one came first and they conflict.

Looks like no conflict.

@wxiaoguang
Copy link
Contributor

Looks like no conflict.

Fortunately there are lines between this change and https://github.com/go-gitea/gitea/pull/34629/files#diff-4b6486152ab1c16e13e39847e4b7a848f2981d55a1b2390c36cd1bec167e545fR177

Since there is a big switch-case and the function already has too many lines, why not move the "case" block to a separate function.

@lunny
Copy link
Member Author

lunny commented Jun 9, 2025

Looks like no conflict.

Fortunately there are lines between this change and https://github.com/go-gitea/gitea/pull/34629/files#diff-4b6486152ab1c16e13e39847e4b7a848f2981d55a1b2390c36cd1bec167e545fR177

Since there is a big switch-case and the function already has too many lines, why not move the "case" block to a separate function.

This is a quick patch to allow backporting to v1.24. The switch-case structure requires a complete refactor, which can be addressed in a separate PR.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 9, 2025
@wxiaoguang wxiaoguang merged commit 9165ea8 into go-gitea:main Jun 9, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the lunny/display_heatmap_when_necessary branch June 9, 2025 13:02
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 9, 2025
@lunny @GiteaBot
Only activity tab needs heatmap data loading (go-gitea#34652)
fd0ca3a
@GiteaBot GiteaBot mentioned this pull request Jun 9, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jun 9, 2025
lunny added a commit that referenced this pull request Jun 9, 2025
@GiteaBot @lunny
Only activity tab needs heatmap data loading (#34652) (#34668)
bf5d000 
Backport #34652 by @lunny

Co-authored-by: Lunny Xiao <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 10, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
333545a 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix last admin check when syncing users (go-gitea#34649)
  Update x/crypto package and make builtin SSH use default parameters (go-gitea#34667)
  Fix "oras" OCI client compatibility (go-gitea#34666)
  Fix: skip paths check on tag push events in workflows (go-gitea#34602)
  Fix footnote jump behavior on the issue page. (go-gitea#34621)
  Only activity tab needs heatmap data loading (go-gitea#34652)
  Ignore "Close" error when uploading container blob (go-gitea#34620)
  Keeping consistent between UI and API about combined commit status state and fix some bugs (go-gitea#34562)
  Refactor FindOrgOptions to use enum instead of bool, fix membership visibility (go-gitea#34629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code performance/speed performance issues with slow downs
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @wxiaoguang @techknowlogick @GiteaBot